Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toned down interstitial text and icon for top-level blocking. #15433

Closed
mkarolin opened this issue Apr 22, 2021 · 2 comments · Fixed by brave/brave-core#8603
Closed

Toned down interstitial text and icon for top-level blocking. #15433

mkarolin opened this issue Apr 22, 2021 · 2 comments · Fixed by brave/brave-core#8603
Assignees
@mkarolin
Labels
l10n needs-text-change This change requires some careful wording. OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.24.x - Release

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Apr 22, 2021 •
edited
Loading

This is a sub-issue to partially address #15189

Only fix text and icon, but do not change the styling.

QA STR:

  1. Start browser.
  2. Go to Settings > Shields
  3. Change Trackers & ads blocking setting to Aggressive
  4. Navigate to https://adcash.com
  5. Verify that the interstitial page that shows up has the updated text, icon, and that the Proceed button is the default.
  6. Verify that Go back and Proceed buttons work correctly.
@mkarolin mkarolin added privacy needs-text-change This change requires some careful wording. l10n privacy/feature User-facing privacy- & security-focused feature work. OS/Android Fixes related to Android browser functionality privacy-pod Feature work for the Privacy & Web Compatibility pod OS/Desktop labels Apr 22, 2021
@mkarolin mkarolin self-assigned this Apr 22, 2021
@mkarolin mkarolin mentioned this issue Apr 22, 2021
Merged
24 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Apr 22, 2021
@mkarolin
Toned down interstitials for top-level blocking.
f6335b3 
Also, switched to Chromium's information (i) icon instead of the red
exclamation point.

Fixes brave/brave-browser#15433
@mkarolin mkarolin added this to the 1.25.x - Nightly milestone Apr 22, 2021
@mkarolin mkarolin mentioned this issue Apr 22, 2021
Merged
7 tasks
@kjozwiak
Copy link
Member

Removing the OS/Android label due to aggressive mode currently missing from shields on Android. I tried enabling it via #brave-domain-block but that didn't seem to work. Without aggressive mode, there doesn't seem to be a way to trigger the needed interstitial page. @srirambv let me know if #brave-domain-block works for you re: seeing the interstitial page when enabled. If it works for you, please re-add the OS/Android label. CCing @pes10k @fmarier

@kjozwiak kjozwiak removed the OS/Android Fixes related to Android browser functionality label Apr 27, 2021
@stephendonner
Copy link

stephendonner commented Apr 30, 2021 •
edited
Loading

Verified PASSED using

Brave 1.24.81 Chromium: 90.0.4430.93 (Official Build) (x86_64)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
  1. Started Brave
  2. Went to Settings > Shields
  3. Changed Trackers & ads blocked setting to Aggressive
  4. Navigated to https://adcash.com
  5. Verified that the interstitial page that shows up has the updated text, icon, and that the Proceed button is the default
  6. Verified that Go back and Proceed buttons worked correctly

Checked both dark and light themes

dark light
Screen Shot 2021-04-29 at 9 48 56 PM Screen Shot 2021-04-29 at 9 49 06 PM

@srirambv srirambv mentioned this issue Aug 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
l10n needs-text-change This change requires some careful wording. OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging a pull request may close this issue.

Toned down interstitials for top-level blocking. brave/brave-core
3 participants
@stephendonner @kjozwiak @mkarolin