Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set AC pref to off for users in Japan #15601

Closed
zenparsing opened this issue May 3, 2021 · 1 comment · Fixed by brave/brave-core#8700
Closed

Do not set AC pref to off for users in Japan #15601

zenparsing opened this issue May 3, 2021 · 1 comment · Fixed by brave/brave-core#8700
Assignees
@zenparsing
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Milestone
1.26.x - Release

Comments

@zenparsing
Copy link

Follow-up to #15444

brave/brave-core#8618 added a state migration which set the AC enabled flag to false for all Japan-region users. This migration should only be applied to desktop, and not Android.
@zenparsing zenparsing added feature/rewards QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels May 3, 2021
@zenparsing zenparsing self-assigned this May 3, 2021
This was referenced May 3, 2021
Closed
Merged
@zenparsing zenparsing added this to the 1.26.x - Nightly milestone May 5, 2021
@zenparsing zenparsing added QA/No and removed QA/Yes labels May 5, 2021
@LaurenWags LaurenWags mentioned this issue May 5, 2021
Merged
24 tasks
@LaurenWags
Copy link
Member

Per discussion with @zenparsing this revert was also applied to desktop in the upgrade case, but the revert has not yet been applied to desktop clean profile case. Added OS/Desktop label to reflect this.

@LaurenWags LaurenWags changed the title Do not set AC pref to off for Android users in Japan Do not set AC pref to off for users in Japan May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.26.x - Release
2 participants
@zenparsing @LaurenWags