Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert setting AC enabled pref to false for Japan users #8700

Merged
merged 1 commit into from
May 5, 2021

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#15601

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

The AC setting pref not be set to false for Android users in Japan. For desktop
users in Japan, AC is currently blocked by State::GetAutoContributeEnabled.
@zenparsing zenparsing requested a review from emerick May 4, 2021 14:57
@zenparsing zenparsing self-assigned this May 4, 2021
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit e03966f into master May 5, 2021
@zenparsing zenparsing deleted the ksmith-revert-ac-disable branch May 5, 2021 12:48
zenparsing pushed a commit that referenced this pull request May 5, 2021
@zenparsing zenparsing added this to the 1.26.x - Nightly milestone May 5, 2021
zenparsing pushed a commit that referenced this pull request May 5, 2021
@LaurenWags
Copy link
Member

LaurenWags commented May 6, 2021

Verified passed using

Brave	1.26.11 Chromium: 90.0.4430.93 (Official Build) nightly (x86_64)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	macOS Version 10.15.7 (Build 19H1030)

Scenario 1 - Upgrade

  1. Install 1.24.x, Japan region, staging environment, persist logs=true
  2. Enable Rewards
  3. Close Brave
  4. Update to 1.26.11
  5. Enable bF & relaunch
  6. On brave://rewards page confirm there is no "Auto-Contribute" pane
  7. Open Preferences file in profile folder.
    --> See brave.rewards.ac.enabled shows "true" as expected since Disable block element picker in private sessions #15444 was reverted

upgrade

Scenario 2 - Clean

  1. Install 1.26.11, Japan region, staging env, persist logs=true
  2. Enable bF & relaunch
  3. Enable Rewards
  4. On brave://rewards page confirm there is no "Auto-Contribute" pane
  5. Open Preferences file in profile folder.
    --> brave.rewards.ac.enabled shows "false". This is not expected however it was discussed with @zenparsing and @Miyayes that this is ok as-is.

clean

Note - Unable to check on Android as Preferences file is not accessible. Confirmed with @zenparsing above tests are sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not set AC pref to off for users in Japan
3 participants