Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reposition Brave Ads custom ad notification to top-right of screen on Windows #15614

Closed
tmancey opened this issue May 4, 2021 · 5 comments · Fixed by brave/brave-core#8698
Closed

Comments

@tmancey
Copy link
Contributor

tmancey commented May 4, 2021

No description provided.

@GeetaSarvadnya
Copy link

@tmancey Needs a small clarification on the issue. This issue is the same as #15624? Also, I could see the P3A label, is this related to P3A? Please provide the test plan in the issue

@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. and removed features/P3A labels Jun 7, 2021
@tmancey
Copy link
Contributor Author

tmancey commented Jun 7, 2021

@GeetaSarvadnya This is now superseded by #15624. Thanks

@GeetaSarvadnya
Copy link

@tmancey Can you provide the test plan, please? The description of the issue says Reposition Brave Ads custom ad notification to top-right of screen on Windows this verification is already covered in #15624 (comment)

@tmancey
Copy link
Contributor Author

tmancey commented Jun 7, 2021

@GeetaSarvadnya Just need to confirm the default position of custom ad notifications on Windows is positioned top-right. Thanks

@GeetaSarvadnya
Copy link

Verification passed on



<!--StartFragment-->
Brave | 1.26.50 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->


  • Confirmed that the default position of custom ad notifications on Windows are positioned top-right
    image

  • Confirmed the default ad notification timeout for custom ad notifications on Windows is 120 seconds

[11320:14312:0608/143903.841:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 939d423f-bf91-420e-ab69-8a32fa7d5799
  creativeInstanceId: 4983dc92-09fd-4e5c-94c3-616a4728c1d9
  creativeSetId: 5bdeab83-048f-48a7-9602-a1092ded123c
  campaignId: 63010037-c230-40db-b41a-3127619b88e4
  advertiserId: 8d2f4191-b76e-4369-8983-3d9ff551c5ad
  segment: untargeted
  title: This is a test
  body: This is a test
  targetUrl: https://www.brave.com
[11320:14312:0608/143903.843:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 939d423f-bf91-420e-ab69-8a32fa7d5799 and creative instance id 4983dc92-09fd-4e5c-94c3-616a4728c1d9
[11320:14312:0608/143903.844:VERBOSE1:confirmations.cc(89)] Confirming view ad for creative instance id 4983dc92-09fd-4e5c-94c3-616a4728c1d9

Confirmed ad timeout and was hidden after 2 minutes

[11320:14312:0608/143903.841:VERBOSE1:ads_service_impl.cc(1819)] Timeout ad notification with uuid 939d423f-bf91-420e-ab69-8a32fa7d5799 in 120 seconds

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants