Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reposition Brave Ads custom ad notification to top-right of screen on Windows #8698

Merged
merged 1 commit into from
May 4, 2021
Merged

Reposition Brave Ads custom ad notification to top-right of screen on Windows #8698

merged 1 commit into from
May 4, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 4, 2021 •
edited
Loading

Resolves brave/brave-browser#15614

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#15614

@tmancey tmancey requested a review from moritzhaller May 4, 2021 13:52
@tmancey tmancey self-assigned this May 4, 2021
@tmancey tmancey requested a review from yachtcaptain23 May 4, 2021 13:55
moritzhaller
moritzhaller approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@tmancey
Copy link
Collaborator Author

tmancey commented May 4, 2021

CI failed due to unrelated errors

@tmancey tmancey merged commit 22526ad into master May 4, 2021
@tmancey tmancey deleted the issues/15614 branch May 4, 2021 20:39
@tmancey tmancey added this to the 1.26.x - Nightly milestone May 4, 2021
kylehickinson pushed a commit that referenced this pull request Jan 29, 2024
@Brandon-T
Fix #8688: Fix URL-Bar not updating sometimes to show the latest cert…
6a8cc08 
… status (#8698)

Trigger cert validation on request failure/cancellation

Added a certificate trust error handling when WebKit throws an error internally and we receive no certs!
This can mess with the URL Bar, interstitial pages, and cert viewer.

Move evaluation of certs to a serial queue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzhaller moritzhaller moritzhaller approved these changes

@yachtcaptain23 yachtcaptain23 Awaiting requested review from yachtcaptain23

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.26.x - Release
Development

Successfully merging this pull request may close these issues.

Reposition Brave Ads custom ad notification to top-right of screen on Windows
2 participants
@tmancey @moritzhaller