Brave Ads crash when loading an ad resource with invalid JSON

[tmancey]

[btlechowski]

Verification passed on

Brave	1.36.106 Chromium: 99.0.4844.45 (Official Build) (64-bit)
Revision	edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS	Ubuntu 18.04 LTS

Verified en_US locale as it is the only one that has VAC.

Verified conversions resource was loaded:

[11166:11166:0226/001838.502363:VERBOSE1:conversions_resource.cc(40)] Successfully loaded resource nnqccijfhvzwyrxpxwjrpmynaiazctqb
[11166:11166:0226/001838.502518:VERBOSE1:conversions_resource.cc(110)] Parsed verifiable conversion resource version 1
[11166:11166:0226/001838.502685:VERBOSE1:conversions_resource.cc(50)] Successfully initialized resource nnqccijfhvzwyrxpxwjrpmynaiazctqb

Replaced the content of the resource with fail word. No crash observed.

[11932:11932:0226/002137.529089:VERBOSE1:conversions_resource.cc(40)] Successfully loaded resource nnqccijfhvzwyrxpxwjrpmynaiazctqb
[11932:11932:0226/002137.529281:VERBOSE1:conversions_resource.cc(65)] Failed to load from JSON, root missing
[11932:11932:0226/002137.529501:VERBOSE1:conversions_resource.cc(43)] Failed to initialize resource nnqccijfhvzwyrxpxwjrpmynaiazctqb

Replaced the content of the resource with {} word. No crash observed.

[12231:12231:0226/002227.542363:VERBOSE1:conversions_resource.cc(40)] Successfully loaded resource nnqccijfhvzwyrxpxwjrpmynaiazctqb
[12231:12231:0226/002227.542420:VERBOSE1:conversions_resource.cc(79)] Failed to load from JSON, conversion patterns missing
[12231:12231:0226/002227.542470:VERBOSE1:conversions_resource.cc(43)] Failed to initialize resource nnqccijfhvzwyrxpxwjrpmynaiazctqb

Made the resource file empty. No crash

[12492:12492:0226/002331.263417:VERBOSE1:conversions_resource.cc(35)] Failed to load resource nnqccijfhvzwyrxpxwjrpmynaiazctqb