Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n packaging not working for Linux #1567

Closed
AtjonTV opened this issue Oct 14, 2018 · 7 comments · Fixed by brave/brave-core#630
Closed

i18n packaging not working for Linux #1567

AtjonTV opened this issue Oct 14, 2018 · 7 comments · Fixed by brave/brave-core#630

Comments

@AtjonTV
Copy link

AtjonTV commented Oct 14, 2018

Description

I just downloaded a new copy of Brave 0.55.13 and it seems to have issues loading i18n strings.

Steps to Reproduce

  1. Download brave-v0.55.13-linux-x64
  2. Extract it
  3. Start the browser
  4. Open the brave rewards menu besides the URL bar

Actual result:

i18n: welcomeHeaderTwo

Expected result:

The header text

Reproduces how often:

More then 5 times

Brave version (chrome://version info)

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) unknown(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Extended OS details:

Distribution: elemetary OS
Distribution Version: 0.4.1 Loki
Base Distribution: Ubuntu 16.04.5
Kernel: Linux 4.15.0-36-generic

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    yes
  • Does it reproduce on browser-laptop?
    no

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Is the issue reproducible on the latest version of Chrome?
    I guess 70.0 is latest so yes

Additional Information

screenshot from 2018-10-14 10 28 31

@AtjonTV
Copy link
Author

AtjonTV commented Oct 14, 2018

I am now going to test with 0.56.3 to see if the same issue occurs.

@AtjonTV
Copy link
Author

AtjonTV commented Oct 14, 2018

Brave 0.56.3 Chromium: 70.0.3538.45 (Official Build) unknown(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

screenshot from 2018-10-14 10 44 57

@NejcZdovc
Copy link
Contributor

cc @bbondy this appears to be a problem on linux as well. Will brave/brave-core#604 fix it for linux as well?

@AtjonTV
Copy link
Author

AtjonTV commented Oct 14, 2018

System Language is English and Brave Language is also English

Changing the Brave Language to German does not change the Language at all 🤔
(I just tested this in Chromium 69 and changing the language does not work too, so it looks like a chromium issue)

@bbondy
Copy link
Member

bbondy commented Oct 14, 2018

The last fix was definitely only for Wibdows, I'll check it out. Note some more work needs to be done to actually add the diff languages, but I'll do just the i18n label fix here.

@srirambv
Copy link
Contributor

Changing the Brave Language to German does not change the Language at all

You need to do the following for browser language to change on Linux

  • Add language packs from system settings
  • Change Language from settings and restart
  • Add preferred language in Browser and relaunch (Available languages might not be completely translated)

Please open a new issue if that doesn't work. Better to track one item per issue rather than combining multiple

@bbondy bbondy changed the title i18n issues on Beta 0.55.13 i18n issues on Linux Oct 14, 2018
@bbondy bbondy changed the title i18n issues on Linux i18n packaging not working for Linux Oct 14, 2018
@bbondy bbondy added QA/Yes and removed QA/Yes labels Oct 14, 2018
bbondy added a commit to brave/brave-core that referenced this issue Oct 14, 2018
@srirambv
Copy link
Contributor

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants