-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ad rewards not updated at brave://rewards due to loss of precision #15801
Labels
feature/ads
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/include
Milestone
Comments
tmancey
added
priority/P3
The next thing for us to work on. It'll ride the trains.
QA/Yes
release-notes/include
feature/ads
OS/Desktop
labels
May 12, 2021
Merged
24 tasks
where is the confirmations.json file? |
@RupeshBhandari these steps are for our support team and not for use outside of Brave |
@tmancey thanks for letting me know. |
Verification passed on
Verified passed with
Verified STR from description.
Verification passed on
Verified STR from description.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/ads
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/include
Description
Ad rewards not updated due to loss of precision
Steps to Reproduce
ads_rewards
node ofconfirmations.json
with CONFIRMATIONS JSON (see below)GET /v1/confirmation/payment/{payment_id}
endpoint to return PAYMENT BALANCE RESPONSE DATA (see below)GET /v1/promotions/ads/grants/summary?paymentId={payment_id}
endpoint to return AD GRANT RESPONSE DATA (see below)Actual result:
Payment balance is not ready
appear in the console logExpected result:
Successfully reconciled ad rewards
should appear in the console logReproduces how often:
Intermittent issue depending on payment balances and ad grant balance
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
CONFIRMATIONS JSON:
PAYMENT BALANCE RESPONSE DATA:
AD GRANT RESPONSE DATA:
The text was updated successfully, but these errors were encountered: