Ads are blocked forever after ads limits (per hour or per day) are reached #15814

btlechowski · 2021-05-13T03:36:09Z

Follow up to #9805

When an ads limit is reached, user will never see an ad, even when the limit should have expired already. Browser restart does not fix this issue.
The user will not see ads ever again

Steps to Reproduce

Follow steps from Brave Ads maximum new tab page ads per hour - 1 per hour - limit expired from https://github.com/brave/internal/issues/759

Note: also reproduced for Notification ads
Note: reproducible also with default values for limits

Actual result:

Ads are blocked forever.
The limit does not expire
Browser restart does not fix this issue

Logs:

[4691:4691:0513/062212.689391:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per hour
[4691:4691:0513/062212.689825:VERBOSE1:new_tab_page_ad.cc(120)] New tab page ad: Not allowed

Expected result:

Ad is shown after limit expires

Reproduces how often:

100% reproduction rate

Brave version (brave://version info)

Reproduced on

Brave	1.25.59 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	Ubuntu 18.04 LTS

Reproduced on

Brave	1.26.18 Chromium: 91.0.4472.38 (Official Build) nightly (64-bit)
Revision	8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS	Ubuntu 18.04 LTS

Not reproducible on

Brave	1.24.84 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	Ubuntu 18.04 LTS

cc @jsecretan @tmancey @moritzhaller @brave/legacy_qa

The text was updated successfully, but these errors were encountered:

LaurenWags · 2021-05-17T11:53:31Z

Labelling as QA/Blocked as this is waiting on an uplift to 1.25.x.

LaurenWags · 2021-05-19T11:55:10Z

Removing QA/Blocked, this should be available to test in https://github.com/brave/brave-browser/releases/tag/v1.25.64

LaurenWags · 2021-05-19T18:14:59Z

Verification in progress with

Brave	1.25.64 Chromium: 90.0.4430.212 (Official Build) beta (x86_64)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	macOS Version 10.15.7 (Build 19H1030)

Executed selected scenarios from https://github.com/brave/internal/issues/759 listed below.

Verified Brave Ads maximum new tab page ads per hour - 1 per hour - limit expired

Verified 1st ad is shown:

[29324:775:0519/113514.880897:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified next ad is blocked:

[29324:775:0519/113632.969004:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per hour
[29324:775:0519/113632.969081:VERBOSE1:new_tab_page_ad.cc(120)] New tab page ad: Not allowed

After 1h, verified ads are shown again:

[29409:775:0519/123821.124381:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified Brave Ads maximum ad notifications per day - multiple profiles - 1 per day - limit expired

Verified 1st ad is shown:

[29951:775:0519/135930.348671:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 37c2b222-d007-46f1-8924-83b07434f2c9
  creativeInstanceId: 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad2 - same set
  body: Ad2 - same set
  targetUrl: https://youtube.com

Verified next ad is blocked:

[29951:775:0519/140128.016935:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed ads per day
[29951:775:0519/140128.017080:VERBOSE1:ad_notification_serving.cc(150)] Ad notification not served: Not allowed
[29951:775:0519/140128.017153:VERBOSE1:ad_notification_serving.cc(91)] Ad notification not delivered

After 24h, verified ads are shown again:

[30078:775:0520/140451.232846:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 3b935459-622d-44cd-b4bf-230fb2206351
  creativeInstanceId: 5b4cb3f4-5285-4597-87c5-3082fe37938a
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad1 - same set
  body: Ad1 - same set
  targetUrl: https://youtube.com

Brave	1.25.65 Chromium: 91.0.4472.57 (Official Build) (x86_64)
Revision	e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS	macOS Version 10.15.7 (Build 19H1030)

Verified Brave Ads maximum new tab page ads per day - multiple profiles - 1 per day - limit expired

Verified 1st ad is shown:

[37222:775:0521/114639.205298:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified next NTP ad is blocked in 2nd profile:

[37222:775:0521/115007.623622:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per day
[37222:775:0521/115007.623715:VERBOSE1:new_tab_page_ad.cc(120)] New tab page ad: Not allowed

After 24h, verified ads are shown again:

[37380:775:0522/115243.088247:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verification passed on

Brave	1.25.65 Chromium: 91.0.4472.57 (Official Build) (64-bit)
Revision	e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS	Ubuntu 18.04 LTS

Verified Brave Ads maximum new tab page ads per hour - 1 per hour - limit expired from https://github.com/brave/internal/issues/759

Verified 1st ad is shown:

[31702:31702:0524/142059.680131:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified next ad is blocked:

[31702:31702:0524/142142.886184:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per hour
[31702:31702:0524/142142.886222:VERBOSE1:new_tab_page_ad.cc(120)] New tab page ad: Not allowed

After 1h, verified ads are shown again:

[32117:32117:0524/153618.549604:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified Brave Ads maximum ad notifications per day - multiple profiles - 1 per day - limit expired from https://github.com/brave/internal/issues/759

Verified 1st ad is shown:

[27838:27838:0524/135753.994262:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: fa1fee2b-494c-44f4-9725-22acea30b097
  creativeInstanceId: 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad2 - same set
  body: Ad2 - same set
  targetUrl: https://youtube.com

Verified next ad is blocked:

[27838:27838:0524/135938.657933:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed ads per day
[27838:27838:0524/135938.657990:VERBOSE1:ad_notification_serving.cc(150)] Ad notification not served: Not allowed
[27838:27838:0524/135938.658049:VERBOSE1:ad_notification_serving.cc(91)] Ad notification not delivered

After 24h, verified ads are shown again:

[29274:29274:0525/140436.543592:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: f1d7a742-d0ff-4932-b3de-c42d056c7432
  creativeInstanceId: 5b4cb3f4-5285-4597-87c5-3082fe37938a
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad1 - same set
  body: Ad1 - same set
  targetUrl: https://youtube.com

Verified Brave Ads maximum new tab page ads per day - multiple profiles - 1 per day - limit expired from https://github.com/brave/internal/issues/759

Verified 1st ad is shown:

[793:793:0524/144050.396168:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified next ad is blocked in 2nd profile:

[793:793:0524/144159.039098:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per day
[793:793:0524/144159.039139:VERBOSE1:new_tab_page_ad.cc(120)] New tab page ad: Not allowed

After 24h, verified ads are shown again:

[1434:1434:0525/144231.835929:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verification passed on


<!--StartFragment-->
Brave | 1.25.66 Chromium: 91.0.4472.70&nbsp;(Official Build)&nbsp;(64-bit)
-- | --
Revision | fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

Executed selected scenarios from https://github.com/brave/internal/issues/759 listed below.

Verified Brave Ads maximum new tab page ads per hour - 1 per hour - limit expired

Verified 1st ad is shown:

[18300:10820:0525/122600.724:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified next ad is blocked:

[18300:10820:0525/122716.533:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per hour
[18300:10820:0525/122716.534:VERBOSE1:new_tab_page_ad.cc(120)] New tab page ad: Not allowed

After 1h, verified ads are shown again:

[9244:7636:0525/133050.282:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified Brave Ads maximum ad notifications per day - multiple profiles - 1 per day - limit expired

Verified 1st ad is shown:

[4280:7620:0525/132420.609:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 56e6a0d1-e691-45e3-ba62-334a858f8adb
  creativeInstanceId: 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad2 - same set
  body: Ad2 - same set
  targetUrl: https://youtube.com

Verified next ad is blocked:

[4280:7620:0525/132639.657:INFO:notification_helper_win.cc(200)] Notifications are enabled
[4280:7620:0525/132639.665:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed ads per day
[4280:7620:0525/132639.666:VERBOSE1:ad_notification_serving.cc(150)] Ad notification not served: Not allowed
[4280:7620:0525/132639.679:VERBOSE1:ad_notification_serving.cc(91)] Ad notification not delivered

After 24h, verified ads are shown again:

[15724:14656:0526/141601.435:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: bf18bb46-8592-4bb4-a617-5083ea52a7e5
  creativeInstanceId: 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad2 - same set
  body: Ad2 - same set
  targetUrl: https://youtube.com

Ensured that after moving the clock 24 hours ahead, Ad is shown and the user is paid for it.

Example	Example

Verified Brave Ads maximum new tab page ads per day - multiple profiles - 1 per day - limit expired

Verified 1st ad is shown:

[8380:10752:0525/143758.729:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified next ad is blocked in 2nd profile:

[8380:10752:0525/144107.197:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per day
[8380:10752:0525/144107.198:VERBOSE1:new_tab_page_ad.cc(120)] New tab page ad: Not allowed

After 24h, verified ads are shown again:

[16796:17164:0526/144545.891:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Ensured that after moving the clock 24 hours ahead, NTP SI is shown and the user is paid for it.

Example	Example

btlechowski added release/blocking QA/Yes QA/Test-Plan-Specified regression feature/ads OS/Desktop labels May 13, 2021

btlechowski added this to the 1.25.x - Beta milestone May 13, 2021

This was referenced May 13, 2021

Fixes Brave ads are blocked forever after ads limits (per hour or per day) are reached brave/brave-core#8801

Merged

Fixes Brave ads are blocked forever after ads limits (per hour or per day) are reached - 1.25.x brave/brave-core#8802

Merged

tmancey closed this as completed in brave/brave-core#8801 May 14, 2021

tmancey self-assigned this May 14, 2021

LaurenWags added the QA/Blocked label May 17, 2021

btlechowski added the QA/Test-All-Platforms label May 17, 2021

tmancey added the release-notes/exclude label May 18, 2021

LaurenWags removed the QA/Blocked label May 19, 2021

LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 19, 2021

btlechowski added the QA Pass-Linux label May 24, 2021

GeetaSarvadnya added the QA Pass-Win64 label May 25, 2021

tmancey added this to Ads Jun 10, 2024

tmancey moved this to Done in Ads Jun 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ads are blocked forever after ads limits (per hour or per day) are reached #15814

Ads are blocked forever after ads limits (per hour or per day) are reached #15814

btlechowski commented May 13, 2021

LaurenWags commented May 17, 2021

LaurenWags commented May 19, 2021

LaurenWags commented May 19, 2021 •

edited by GeetaSarvadnya

Loading

Ads are blocked forever after ads limits (per hour or per day) are reached #15814

Ads are blocked forever after ads limits (per hour or per day) are reached #15814

Comments

btlechowski commented May 13, 2021

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

LaurenWags commented May 17, 2021

LaurenWags commented May 19, 2021

LaurenWags commented May 19, 2021 • edited by GeetaSarvadnya Loading

LaurenWags commented May 19, 2021 •

edited by GeetaSarvadnya

Loading