Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce maximum number of ads displayed across all user profiles #9805

Closed
tmancey opened this issue May 16, 2020 · 1 comment · Fixed by brave/brave-core#8469
Closed

Enforce maximum number of ads displayed across all user profiles #9805

tmancey opened this issue May 16, 2020 · 1 comment · Fixed by brave/brave-core#8469

Comments

@tmancey
Copy link
Contributor

tmancey commented May 16, 2020

No description provided.

@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include QA/Yes OS/Desktop labels Jul 10, 2020
@tmancey tmancey changed the title Maximum number of ads should be enforced beyond the profile [Desktop] Maximum number of ads should be enforced beyond the profile Jul 10, 2020
@tmancey tmancey changed the title [Desktop] Maximum number of ads should be enforced beyond the profile Maximum number of ads should be enforced beyond the profile Aug 5, 2020
@tmancey tmancey added OS/Android Fixes related to Android browser functionality and removed QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include labels Aug 5, 2020
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include and removed OS/Android Fixes related to Android browser functionality labels Aug 20, 2020
@srirambv srirambv changed the title Maximum number of ads should be enforced beyond the profile [Desktop] Maximum number of ads should be enforced beyond the profile Sep 9, 2020
@tmancey tmancey removed QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include labels Oct 6, 2020
@tmancey tmancey changed the title [Desktop] Maximum number of ads should be enforced beyond the profile Maximum number of ads should be enforced beyond the profile Dec 5, 2020
@tmancey tmancey changed the title Maximum number of ads should be enforced beyond the profile Maximum number of ads should be enforced across all user profiles Mar 8, 2021
@tmancey tmancey removed QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude labels Mar 12, 2021
@tmancey tmancey changed the title Maximum number of ads should be enforced across all user profiles Enforce maximum number of ads displayed across all user profiles Mar 12, 2021
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Mar 30, 2021
@tmancey tmancey self-assigned this Mar 30, 2021
@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 6, 2021
@tmancey tmancey added this to the 1.25.x - Nightly milestone Apr 8, 2021
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 9, 2021
@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 6, 2021
@btlechowski
Copy link

btlechowski commented May 13, 2021

Verification passed on

Brave 1.25.53 Chromium: 90.0.4430.93 (Official Build) beta (64-bit)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/internal/issues/759

Verified Brave Ads maximum ad notifications per day - multiple profiles - 1 per day
Verified 2nd ad was not shown in the second profile
Verified the logs

[18838:18838:0513/030533.304865:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed ads per day
[18838:18838:0513/030533.304961:VERBOSE1:ad_notification_serving.cc(150)] Ad notification not served: Not allowed
[18838:18838:0513/030533.305037:VERBOSE1:ad_notification_serving.cc(91)] Ad notification not delivered

Verified Brave Ads maximum new tab page ads per hour - multiple profiles - 1 per hour
First ad was shown in the first profile:

[24265:24265:0513/033529.950713:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified 2nd ad in second profile was not counted

[24265:24265:0513/033714.106877:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per hour
[24265:24265:0513/033714.109803:VERBOSE1:new_tab_page_ad.cc(120)] New tab page ad: Not allowed

Verified Brave Ads maximum new tab page ads per day - multiple profiles - 1 per day
First ad was shown in the first profile:

[20532:20532:0513/043834.236334:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified 2nd ad in second profile was not counted

[20532:20532:0513/044038.445985:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per day
[20532:20532:0513/044038.446068:VERBOSE1:new_tab_page_ad.cc(120)] New tab page ad: Not allowed

Promoted Content is not tested because it is not used yet and there are no promoted content ads on production, staging nor dev servers.

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 13, 2021
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants