Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button on FTX is always shown #15941

Closed
srirambv opened this issue May 18, 2021 · 2 comments · Fixed by brave/brave-core#8947
Closed

Back button on FTX is always shown #15941

srirambv opened this issue May 18, 2021 · 2 comments · Fixed by brave/brave-core#8947

Comments

@srirambv
Copy link
Contributor

Description

Back button on FTX is always shown

Steps to Reproduce

  1. Install 1.26.22 nightly build
  2. Open Futures market on FTX widget
  3. Background the widget, back button is still shown all the time

Actual result:

image image image

Expected result:

Back button on the widget should only be shown when the widget is in foreground

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.26.22 Chromium: 91.0.4472.57 (Official Build) nightly (64-bit)
Revision e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @rebron @petemill @simonhong

@petemill
Copy link
Member

Hmm I think the back button with some space, like FTX is probably best. The solution here is probably to hide the back button when the widget is not in the foreground since it won't do anything.

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 26, 2021
@simonhong simonhong added this to the 1.27.x - Nightly milestone Jun 9, 2021
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.26.63 Chromium: 91.0.4472.106 (Official Build) (x86_64)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS macOS Version 10.15.7 (Build 19H114)
  • Verified back button is only shown when widget is in focus
15941-mac.mov

Verification passed on

Brave 1.26.63 Chromium: 91.0.4472.106 (Official Build) (64-bit)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS Linux
  • Verified back button is only shown when widget is in focus
15941-Linux.mov

Verification passed on

Brave 1.26.63 Chromium: 91.0.4472.106 (Official Build) (64-bit)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS Windows 10 OS Version 2009 (Build 19042.1052)
  • Verified back button is only shown when widget is in focus
15941-Win.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants