Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow private (& private+Tor) search engines to be changed #1609

Closed
tildelowengrimm opened this issue Oct 16, 2018 · 3 comments
Closed

Allow private (& private+Tor) search engines to be changed #1609

tildelowengrimm opened this issue Oct 16, 2018 · 3 comments

Comments

@tildelowengrimm
Copy link
Contributor

Currently, private windows have an immutable search engine. That's silly.

@tildelowengrimm tildelowengrimm added feature/tor feature/global-settings Settings at browser level independent of shields settings feature/private-browsing labels Oct 16, 2018
@simonhong
Copy link
Member

simonhong commented Oct 16, 2018

Search engine provider works like below

  • Private window (non-tor)
    • DDG is used when it's option is on in private newtab
    • Normal windows's provider is used when ddg option is off
  • Private tor window

@bbondy bbondy added this to the 1.x Backlog milestone Oct 16, 2018
@riastradh-brave riastradh-brave self-assigned this Oct 16, 2018
@simonhong
Copy link
Member

@riastradh-brave I think this issue can be closed?

@rebron rebron removed this from the 1.x Backlog milestone Oct 19, 2018
@rebron
Copy link
Collaborator

rebron commented Oct 19, 2018

Fixed in RC builds. Reopen if it's not.

@rebron rebron closed this as completed Oct 19, 2018
@bbondy bbondy removed feature/global-settings Settings at browser level independent of shields settings feature/private-browsing feature/tor labels Oct 28, 2018
@bbondy bbondy added this to the Dupe / Invalid / Not actionable milestone Oct 28, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants