Consider Qwant search provider as a initial provider in tor window #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Qwant is default prepopulate search provider, use it as an initial search engine provider of tor window. Otherwise, DDG is used. When user changes search provider setting, it will be persisted.
simonhong
force-pushed
the
qwant_search_provider
branch
from
74bbf03 to
cd8ede4
Compare
darkdh
reviewed
Oct 16, 2018
| @@ -18,14 +19,13 @@ TorWindowSearchEngineProviderController(Profile* profile) | |||
|
|
|||
| alternative_search_engine_provider_in_tor_.Init( | |||
| kAlternativeSearchEngineProviderInTor, | |||
| otr_profile_->GetOriginalProfile()->GetPrefs()); | |||
| profile->GetOriginalProfile()->GetPrefs()); | |||
There was a problem hiding this comment.
can you explain why GetOriginalProfile from regular profile? That will just return itself
There was a problem hiding this comment.
|profile| is off the record profile.
There was a problem hiding this comment.
I see. I just checked the caller.
darkdh
approved these changes
Oct 16, 2018
|
Tried it:
|
|
So does this fix #647? |
|
@riastradh-brave I think you meant brave/brave-browser#1607 |
|
@darkdh oops, yes, I did mean brave/brave-browser#1607. |
|
@riastradh-brave no- that is fixed with #654 I believe |
darkdh
pushed a commit
that referenced
this pull request
Oct 17, 2018
Consider Qwant search provider as a initial provider in tor window
darkdh
pushed a commit
that referenced
this pull request
Oct 17, 2018
Consider Qwant search provider as a initial provider in tor window
darkdh
pushed a commit
that referenced
this pull request
Oct 17, 2018
Consider Qwant search provider as a initial provider in tor window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Qwant is default prepopulate search provider, use it as an
initial search engine provider of tor window. Otherwise, DDG is used.
When user changes search provider setting, it will be persisted.
Fixes brave/brave-browser#1514
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: