Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards panel doesn't list IPFS links fully in panel #16612

Closed
srirambv opened this issue Jun 25, 2021 · 5 comments · Fixed by brave/brave-core#9375
Closed

Rewards panel doesn't list IPFS links fully in panel #16612

srirambv opened this issue Jun 25, 2021 · 5 comments · Fixed by brave/brave-core#9375

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 25, 2021

Description

Rewards should work only for ipns + dnslink case, all others ipfs urls should be disabled

Steps to Reproduce

  1. Visit an IPFS URI
  2. Open rewards panel
  3. Shows incomplete link

Actual result:

image

Expected result:

It should work only for ipns + dnslink case, all others should be disabled

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.28.27 Chromium: 91.0.4472.120 (Official Build) nightly (64-bit)
Revision 12c5925972cffe578ca7ca7a295e98ee7e178a7a-refs/branch-heads/4472@{#1506}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @bridiver @spylogsster

Related to #14841

@zenparsing
Copy link

See #16612 for a previous related issue.

@stephendonner
Copy link

See #16612 for a previous related issue.

That's this bug; did you mean #14841?

@bridiver
Copy link
Contributor

bridiver commented Jul 6, 2021

This issue is "won't fix" as written because we don't currently (and maybe never will have) a process for validating IPFS CID. We may or may not want to implement this for dnslink only. @bbondy ?

@bbondy
Copy link
Member

bbondy commented Jul 6, 2021

Updated the original issue to add "It should work only for ipns + dnslink case, all others should be disabled"

@stephendonner
Copy link

Verified FIXED using

Brave 1.29.12 Chromium: 92.0.4515.101 (Official Build) nightly (x86_64)
Revision edb73f4fb624e2ea0cb6f5cc39c9e317ecd3535b-refs/branch-heads/4515@{#1536}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. loaded the following: ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html, https://wikipedia-on-ipfs.org, and ipns://en.wikipedia-on-ipfs.org/wiki/
  4. confirmed only ipns:// links and regular https:// links showed in the Rewards UI
ipns://en.wikipedia-on-ipfs.org/wiki/ https://wikipedia-on-ipfs.org ipfs://bafybeiemxf5abjwjbik<snip>/wiki/Vincent_van_Gogh.html
Screen Shot 2021-07-20 at 9 52 04 AM Screen Shot 2021-07-20 at 9 50 50 AM Screen Shot 2021-07-20 at 9 51 48 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment