Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr92 followup] Settings page is blank #16708

Closed
mkarolin opened this issue Jun 30, 2021 · 1 comment · Fixed by brave/brave-core#9288
Closed

[cr92 followup] Settings page is blank #16708

mkarolin opened this issue Jun 30, 2021 · 1 comment · Fixed by brave/brave-core#9288
Assignees
@mkarolin
Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.27.x - Release

Comments

@mkarolin
Copy link
Contributor

The brave://settings page is blank and there's an error in the console:

[Brave Settings Overrides] Could not find menu item '/safetyCheck'

STR:

  1. Start Brave
  2. Navigate to brave://settings

Observe: the settings page is blank
Expected results: settings are shown
@mkarolin mkarolin self-assigned this Jun 30, 2021
@mkarolin mkarolin mentioned this issue Jun 30, 2021
Merged
24 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Jun 30, 2021
@mkarolin
[cr92 followup] Fixes blank settings page.
7832284 
The page is blank because the /safetyCheck menu item cannot be found.
This happens because the menu item is no longer a direct child of the
menu, but instead is nested in a template.

Added code to search templates for menu items (perhpas there's a more
efficient way?).

Fixes brave/brave-browser#16708

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/49cea54a

commit 49cea54a094586e441513055fe0febedba4f377d
Author: dpapad <dpapad@chromium.org>
Date:   Fri May 14 08:53:26 2021 +0000

    Settings: Combine safetyCheck and privacy sections in re-design.

     - Hide the "Safety check" menu entry
     - Add a new |nest-under-section| attribute on <settings-section> and
       leverage it in main_page_behavior.js to show multiple
       <settings-section> instances at the same time.
     - Update tests.

    Bug: 1204457
@mkarolin mkarolin mentioned this issue Jun 30, 2021
Merged
24 tasks
@mkarolin mkarolin added this to the 1.28.x - Nightly milestone Jul 1, 2021
@mkarolin mkarolin mentioned this issue Jul 7, 2021
Merged
24 tasks
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 15, 2021 •
edited by LaurenWags
Loading

Verification passed on


Brave | 1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | Windows 10 OS Version 2004 (Build 19041.1083)
  • Confirmed that brave://settings and sub-settings loaded successfully and click on each setting redirected to the correct section and settings works as expected

General settings

Example Example Example Example Example Example Example Example
image image image image image image image image

Additional settings

Example Example Example Example
image image image image

Verification passed on

Brave 1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS Ubuntu 18.04 LTS
  • Confirmed that brave://settings and sub-settings loaded successfully and click on each setting redirected to the correct section and settings works as expected

image
image
image

Verified passed with

Brave | 1.27.105 Chromium: 92.0.4515.93 (Official Build) (x86_64)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | macOS Version 10.15.7 (Build 19H1217)
  • Confirmed that brave://settings loaded as expected
  • Confirmed able to navigate using the left menu and the and sub-settings loaded as expected
  • Confirmed able to click on various settings which navigated to a sub-page and those sub-pages loaded as expected
Example Example Example Example Example
1 2 3 4 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging a pull request may close this issue.

[cr92 followup] Fixes blank settings page. brave/brave-core
4 participants
@LaurenWags @btlechowski @GeetaSarvadnya @mkarolin