Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't connect to Google for translations #1674

Closed
tildelowengrimm opened this issue Oct 17, 2018 · 1 comment · Fixed by brave/brave-core#679
Closed

Don't connect to Google for translations #1674

tildelowengrimm opened this issue Oct 17, 2018 · 1 comment · Fixed by brave/brave-core#679
Labels
audit-release priority/P2 A bad problem. We might uplift this to the next planned release. privacy/connect This requires making a network connection to a third-party service. privacy QA/No
Milestone
0.55.x - Release ...

Comments

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Oct 17, 2018 •
edited
Loading

On startup, we seem to make connections to https://www.gstatic.com/chrome/intelligence/assist/ranker/models/translate/translate_ranker_20180123.model. We shouldn't.

Related to #663.
@tildelowengrimm tildelowengrimm added privacy priority/P2 A bad problem. We might uplift this to the next planned release. audit-beta audit-release privacy/connect This requires making a network connection to a third-party service. labels Oct 17, 2018
@pilgrim-brave pilgrim-brave mentioned this issue Oct 18, 2018
Merged
18 tasks
@bbondy bbondy added QA/Yes and removed audit-beta labels Oct 18, 2018
@diracdeltas diracdeltas mentioned this issue Oct 18, 2018
Closed
@srirambv
Copy link
Contributor

srirambv commented Oct 18, 2018 •
edited
Loading

Verification Passed on

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux

image

Edit: Gstatic link shows up after a delay. Marking as No QA . Should be covered by #1715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit-release priority/P2 A bad problem. We might uplift this to the next planned release. privacy/connect This requires making a network connection to a third-party service. privacy QA/No
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Disable RankerURLFetcher brave/brave-core
4 participants
@tildelowengrimm @bbondy @srirambv @btlechowski