Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estimated pending rewards does not reset to expected value when you have uncashed in tokens - follow up to #16678 #16744

Closed
LaurenWags opened this issue Jul 1, 2021 · 2 comments · Fixed by brave/brave-core#9309
Assignees
Labels
bug feature/ads OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

Fix for #16678 works great, except when a user has uncashed in tokens. In the likely event that a user has tokens which have not been cashed in with the server, this will not work. So a user will still see incorrect pending BAT for current month.

Steps to Reproduce

  1. Have a profile in the bad state with uncashed in tokens
  2. Launch with 1.28.46
  3. Look at UI and logs

Actual result:

ads panel UI does not accurately reflect estimated pending BAT (for current month or the coming ad grant)

logs still show

[21660:775:0701/163623.792441:INFO:ad_rewards.cc(280)] Payment balance is not ready
[21660:775:0701/163623.792517:VERBOSE1:ad_rewards.cc(355)] Failed to reconcile ad rewards

Expected result:

Ads panel UI to be correct, no such messages in logs

Reproduces how often:

100% for my personal case

Brave version (brave://version info)

Brave	1.28.46 Chromium: 92.0.4515.70 (Official Build) nightly (x86_64)
Revision	2df01a82398e62190b2aae01aaad7ca3d47aba01-refs/branch-heads/4515@{#923}
OS	macOS Version 10.15.7 (Build 19H1217)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @tmancey @kjozwiak @jsecretan

@kjozwiak
Copy link
Member

kjozwiak commented Jul 6, 2021

@brave/legacy_qa please leave this one as we're planning on uplifting this into 1.26.x. @LaurenWags will run through this one once we get a new 1.27.x dev build created.

@LaurenWags
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/ads OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude
Projects
Archived in project
3 participants