Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected error messages in logs - follow up to #16810 #16835

Closed
LaurenWags opened this issue Jul 8, 2021 · 3 comments · Fixed by brave/brave-core#9370
Closed

unexpected error messages in logs - follow up to #16810 #16835

LaurenWags opened this issue Jul 8, 2021 · 3 comments · Fixed by brave/brave-core#9370
Assignees
Labels
bug feature/ads OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

Still receiving error messages in logs after checking #16810.

Steps to Reproduce

  1. Have a profile that was affected by estimated pending rewards does not reset to expected value when you have uncashed in tokens - follow up to #16678 #16744
  2. Launch with 1.28.62
  3. See that ad panel UI shows approximately expected estimated BAT
  4. Look at logs

Actual result:

Still see Payment balance is not ready and Failed to reconcile ad rewards messages in logs after OnGetPayments

Expected result:

No error messages

Reproduces how often:

easily if affected

Brave version (brave://version info)

1.28.62

Version/Channel Information:

  • Can you reproduce this issue with the current release? likely yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @tmancey @kjozwiak

@LaurenWags
Copy link
Member Author

@stephendonner
Copy link

(Removed QA/Yes since it's marked QA/No - please revert if I'm in error.)

@LaurenWags
Copy link
Member Author

whoops, missed removing that label. thanks @stephendonner 👍🏻

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/ads OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants