Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR92- This file can't be downloaded securely mixed-content text is unreadable #16865

Closed
stephendonner opened this issue Jul 8, 2021 · 2 comments · Fixed by brave/brave-core#9391

Comments

@stephendonner
Copy link

stephendonner commented Jul 8, 2021

Description

This file can't be downloaded securely mixed-content text is unreadable

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load https://www.leaseweb.com/platform/network and scroll down to Bandwidth Capacity
  4. right-click any file and choose Save link as... and click Save in the resulting file-picker dialog
  5. look at the bottom download tray/bar
  6. click the ^ arrow and then Learn more

Actual result:

  • The text is garbled
  • The Learn more link goes to top-level https://support.brave.com/hc/en-us

Screen Shot 2021-07-08 at 4 25 27 PM

On Chrome (92.0.4515.93 (Official Build) beta (x86_64))

  • The text is readable
  • The Learn more link goes to https://support.google.com/chrome/answer/6261569?p=mixed_content_downloads&visit_id=637613837836535010-3633976846&rd=1

Expected result:

Screen Shot 2021-07-08 at 4 33 59 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.64 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? yes

/cc @mkarolin @rebron @karenkliu

mkarolin added a commit to brave/brave-core that referenced this issue Jul 9, 2021
Currently, we do not show download origin when a warning dialog is shown
in the download item. We need to do the same for when mixed content
dialog is shown. The origin is only menat to be shown for
active/completed downloads.

Fixes brave/brave-browser#16865
@GeetaSarvadnya GeetaSarvadnya changed the title This file can't be downloaded securely mixed-content text is unreadable CR92- This file can't be downloaded securely mixed-content text is unreadable Jul 12, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 12, 2021

Reproduced on Windows 10 x64 - 1.28.70 - This issue is specific to CR 92 works fine in CR 91

CR 91: 1.26.x - Text content is not overlapping
image

CR 92: 1.28.x - Text content is overlapping
image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 15, 2021

Verification passed on


Brave | 1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | Windows 10 OS Version 2004 (Build 19041.1083)

  • Verified the STR from the description and ensured text content is not overlapped
    image
  • Confirmed notepad and other .exe files are downloaded successfully
    image

Verification passed on

Brave 1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description and ensured text content is not overlapped
    image

Verified passed with

Brave | 1.27.105 Chromium: 92.0.4515.93 (Official Build) (x86_64)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | macOS Version 10.15.7 (Build 19H1217)
  • Verified the STR from the description and ensured text content is not overlapped

16865

  • Confirmed able to download other .zip files:

bravemediaassets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment