Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicked Brave News ad doesn't receive payout nor show up in brave://rewards, but does appear in 30-days ads history #17062

Closed
stephendonner opened this issue Jul 21, 2021 · 4 comments

Comments

@stephendonner
Copy link

Description

Clicked Brave News ad doesn't receive payout nor show up in brave://rewards, but does appear in 30-days ads history

Steps to Reproduce

  1. new profile
  2. launch Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
  3. open a new-tab page
  4. click on Start using Rewards
  5. scroll down
  6. click on Enable Brave News
  7. scroll down and click on an ad with the BAT logo in the upper-right corner
  8. ensure you get the landing page, and wait at least 10 seconds
  9. load brave://rewards
  10. look for:
  • current earnings this month
  • # of ads received this month

Actual result:

  • current earnings this month is 0.000 BAT
  • # of ads received this month is 0.

Screen Shot 2021-07-20 at 6 11 13 PM

Clicked Brave News ad shows up in 30-days ad history

Screen Shot 2021-07-20 at 6 11 18 PM

Expected result:

Should probably receive 0.010 BAT (or similar) for current earnings this month (estimated) and # of ads this month should read 1.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.29.12 Chromium: 92.0.4515.101 (Official Build) nightly (x86_64)
Revision edb73f4fb624e2ea0cb6f5cc39c9e317ecd3535b-refs/branch-heads/4515@{#1536}
OS macOS Version 11.4 (Build 20F71)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes
@btlechowski
Copy link

I think this issue is invalid as user is paid for view events and not click events.

The reason why don't get a view event could be #17136

If the ad is fully confined to the viewport then everything works, view event is triggered and user is paid:

[3834:3834:0723/183316.996834:VERBOSE3:inline_content_ad_event_served.cc(24)] Served inline content ad with uuid d01dd7af-5a4d-4f11-9ef9-44df9efc4112 and creative instance id bf46745c-4fc6-4c30-ad0d-517eecb2137e
[3834:3834:0723/183317.008492:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event
[3834:3834:0723/183317.018187:VERBOSE1:eligible_inline_content_ads.cc(89)] Get eligible ads for parent-child segments:
[3834:3834:0723/183317.018409:VERBOSE1:eligible_inline_content_ads.cc(91)]   untargeted
[3834:3834:0723/183317.020514:VERBOSE2:exclusion_rule_util.h(26)] creativeInstanceId bf46745c-4fc6-4c30-ad0d-517eecb2137e has exceeded the frequency capping for perHour
[3834:3834:0723/183317.029057:VERBOSE2:ad_priority.h(32)] 3 ads with a priority of 1 in bucket 1
[3834:3834:0723/183317.029534:VERBOSE1:inline_content_ad_serving.cc(73)] Found 3 eligible ads
[3834:3834:0723/183317.029831:VERBOSE1:inline_content_ad_serving.cc(98)] Serving inline content ad:
  uuid: dc9e4556-1e7c-4b2f-b825-428666f4e90a
  creativeInstanceId: e837131f-13da-46ae-b8d2-a7f9d00efb2f
  creativeSetId: 1ab4f8ae-4a3e-47a7-a6fe-9ab662ad17cf
  campaignId: 28dbd338-aaf8-44c0-b3d9-01df58ce2c04
  advertiserId: 401acfad-2cbb-4bfc-b522-ceae781f3045
  segment: untargeted
  title: Add some extra Brave to your coffee with a Brave mug!
  description: Brave Swag Store
  imageUrl: https://pcdn.bravesoftware.com/brave-ads/b16f8038-799d-5973-ba67-075297caa2c4.webp.pad
  dimensions: 900x750
  ctaText: Buy now!
  targetUrl: https://store.brave.com/#/collections/work-from-home/products/brave-mug
[3834:3834:0723/183317.035581:VERBOSE3:inline_content_ad_event_served.cc(24)] Served inline content ad with uuid dc9e4556-1e7c-4b2f-b825-428666f4e90a and creative instance id e837131f-13da-46ae-b8d2-a7f9d00efb2f
[3834:3834:0723/183317.048030:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event
[3834:3834:0723/183414.112666:VERBOSE3:inline_content_ad_event_viewed.cc(25)] Viewed inline content ad with uuid dc9e4556-1e7c-4b2f-b825-428666f4e90a and creative instance id e837131f-13da-46ae-b8d2-a7f9d00efb2f
[3834:3834:0723/183414.113147:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id e837131f-13da-46ae-b8d2-a7f9d00efb2f
[3834:3834:0723/183414.115479:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[3834:3834:0723/183414.115652:VERBOSE1:redeem_unblinded_token.cc(64)] CreateConfirmation
[3834:3834:0723/183414.115731:VERBOSE2:redeem_unblinded_token.cc(65)] POST /v1/confirmation/{confirmation_id}/{credential}
[3834:3834:0723/183414.115795:VERBOSE5:redeem_unblinded_token.cc(69)] URL Request:
  URL: https://ads-serve.brave.com/v1/confirmation/a3bce4a1-795c-4607-ba39-b1e6afd7f52f/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiRG1DQU9xb0dIeWtSU2k3WDBwbURmZVNLejlpbVpOSG8yRnpaMDU1UGlGRT1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCJlODM3MTMxZi0xM2RhLTQ2YWUtYjhkMi1hN2Y5ZDAwZWZiMmZcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6IkZWeWdvV1FmcUVyMUVoNWowWWEzM2JXRU9GaXdiL2wwMmo2UGNEOURqVW9tOHRIUWtUdVhPZ3ZSUit4V2xhdko4K0lWZXJzckdYSDRPL2xncjJEU2l3PT0iLCJ0IjoicXE4bHBMMVRNbnVQTVl5aFJ0UDUvM0hVdm42a0Q4Z1pQZFQwam0xdmI3K1dXMFRDMWdCdnNYYlg5RENJK3U5aVBMVVp5andOTVQwSS9MSnhRbVE5enc9PSJ9
  Content: {"blindedPaymentToken":"DmCAOqoGHykRSi7X0pmDfeSKz9imZNHo2FzZ055PiFE=","buildChannel":"nightly","creativeInstanceId":"e837131f-13da-46ae-b8d2-a7f9d00efb2f","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: POST
[3834:3834:0723/183414.134306:VERBOSE6:inline_content_ad_event_viewed.cc(33)] Successfully logged inline content ad viewed event
[3834:3834:0723/183414.738881:VERBOSE1:redeem_unblinded_token.cc(82)] OnCreateConfirmation
[3834:3834:0723/183414.739125:VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
  URL: https://ads-serve.brave.com/v1/confirmation/a3bce4a1-795c-4607-ba39-b1e6afd7f52f/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiRG1DQU9xb0dIeWtSU2k3WDBwbURmZVNLejlpbVpOSG8yRnpaMDU1UGlGRT1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCJlODM3MTMxZi0xM2RhLTQ2YWUtYjhkMi1hN2Y5ZDAwZWZiMmZcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6IkZWeWdvV1FmcUVyMUVoNWowWWEzM2JXRU9GaXdiL2wwMmo2UGNEOURqVW9tOHRIUWtUdVhPZ3ZSUit4V2xhdko4K0lWZXJzckdYSDRPL2xncjJEU2l3PT0iLCJ0IjoicXE4bHBMMVRNbnVQTVl5aFJ0UDUvM0hVdm42a0Q4Z1pQZFQwam0xdmI3K1dXMFRDMWdCdnNYYlg5RENJK3U5aVBMVVp5andOTVQwSS9MSnhRbVE5enc9PSJ9
  Response Status Code: 201
  Response: {"id":"a3bce4a1-795c-4607-ba39-b1e6afd7f52f","payload":{},"createdAt":"2021-07-23T16:34:15.492Z","type":"view","modifiedAt":"2021-07-23T16:34:15.492Z","creativeInstanceId":"e837131f-13da-46ae-b8d2-a7f9d00efb2f"}
[3834:3834:0723/183414.739277:VERBOSE1:redeem_unblinded_token.cc(112)] FetchPaymentToken
[3834:3834:0723/183414.739350:VERBOSE2:redeem_unblinded_token.cc(113)] GET /v1/confirmation/{confirmation_id}/paymentToken
[3834:3834:0723/183414.739427:VERBOSE5:redeem_unblinded_token.cc(117)] URL Request:
  URL: https://ads-serve.brave.com/v1/confirmation/a3bce4a1-795c-4607-ba39-b1e6afd7f52f/paymentToken
  Method: GET
[3834:3834:0723/183415.134989:VERBOSE1:redeem_unblinded_token.cc(128)] OnFetchPaymentToken
[3834:3834:0723/183415.135339:VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
  URL: https://ads-serve.brave.com/v1/confirmation/a3bce4a1-795c-4607-ba39-b1e6afd7f52f/paymentToken
  Response Status Code: 200
  Response: {"id":"a3bce4a1-795c-4607-ba39-b1e6afd7f52f","createdAt":"2021-07-23T16:34:15.492Z","type":"view","modifiedAt":"2021-07-23T16:34:15.501Z","creativeInstanceId":"e837131f-13da-46ae-b8d2-a7f9d00efb2f","paymentToken":{"publicKey":"oOJO/xLaCXGW6yhpeIfM4K1X2ln7sgdjTCTCHe8BugE=","batchProof":"lphecwDcZyw4ePLSxXXzZla/ygDD+YIB5LvW8YyQ3A3c8BIckspx7kcz7W5fTC7nXOS7MTgLj2lmYa/6xf7ZBw==","signedTokens":["3vMfpXup16C39neDGv5eirs5goX5bpCkWzXnVclgny4="]}}
[3834:3834:0723/183415.135569:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id a3bce4a1-795c-4607-ba39-b1e6afd7f52f, creative instance id e837131f-13da-46ae-b8d2-a7f9d00efb2f and view
[3834:3834:0723/183415.135847:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens

@petemill
Copy link
Member

So can we close this @btlechowski @stephendonner ?

@stephendonner
Copy link
Author

So can we close this @btlechowski @stephendonner ?

Yup! Just got the same experience Bart did (the correct one) 👍

Brave 1.29.45 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS macOS Version 12.0 (Build 21A5294g)
[6571:259:0802/180139.873364:VERBOSE1:inline_content_ad_serving.cc(98)] Serving inline content ad:
  uuid: f5991bca-4aa8-4e0b-b13e-54ee973e669d
  creativeInstanceId: 033a95ca-963b-460c-b203-8181346bd41c
  creativeSetId: 6c875e23-00ea-4f1b-805b-5d52559f96da
  campaignId: 8a5ca6f0-f919-461b-8bf2-4848e34ab616
  advertiserId: aa1d1cdb-ec45-42d4-86d0-ea353e1babd4
  segment: untargeted
  title: Makita LF1000 Flip Over Saw
  description: Makita
  imageUrl: https://pcdn.bravesoftware.com/brave-ads/image-1.jpg.pad
  dimensions: 900x750
  ctaText: Learn more
  targetUrl: https://www.powertools2u.co.uk/makita-lf1000-flip-over-sawo
[6571:259:0802/180139.874845:VERBOSE3:inline_content_ad_event_served.cc(24)] Served inline content ad with uuid f5991bca-4aa8-4e0b-b13e-54ee973e669d and creative instance id 033a95ca-963b-460c-b203-8181346bd41c
[6571:259:0802/180139.880111:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event

<snip>

[6571:259:0802/180214.163773:VERBOSE3:inline_content_ad_event_viewed.cc(25)] Viewed inline content ad with uuid f5991bca-4aa8-4e0b-b13e-54ee973e669d and creative instance id 033a95ca-963b-460c-b203-8181346bd41c
[6571:259:0802/180214.164130:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 033a95ca-963b-460c-b203-8181346bd41c
[6571:259:0802/180214.164979:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[6571:259:0802/180214.165047:VERBOSE1:redeem_unblinded_token.cc(64)] CreateConfirmation
[6571:259:0802/180214.165092:VERBOSE2:redeem_unblinded_token.cc(65)] POST /v1/confirmation/{confirmation_id}/{credential}
[6571:259:0802/180214.165138:VERBOSE5:redeem_unblinded_token.cc(69)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/4...
  Content: {"blindedPaymentToken":"Sq8l8FoVRV7nsGGZbByR24i2QIHwExSSfSpu1BkhfyM=","buildChannel":"nightly","creativeInstanceId":"033a95ca-963b-460c-b203-8181346bd41c","payload":{},"platform":"macos","studies":[],"type":"view"}
  Content Type: application/json
  Method: POST
[6571:259:0802/180214.165839:VERBOSE6:inline_content_ad_event_viewed.cc(33)] Successfully logged inline content ad viewed event
[6571:259:0802/180214.598455:VERBOSE1:redeem_unblinded_token.cc(82)] OnCreateConfirmation
[6571:259:0802/180214.598570:VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/4...
  Response Status Code: 201
  Response: {"id":"447b02a5-9af6-42ec-bfb1-eda71c806b60","payload":{},"createdAt":"2021-08-03T01:02:14.594Z","type":"view","modifiedAt":"2021-08-03T01:02:14.595Z","creativeInstanceId":"033a95ca-963b-460c-b203-8181346bd41c"}
[6571:259:0802/180214.598766:VERBOSE1:redeem_unblinded_token.cc(112)] FetchPaymentToken
[6571:259:0802/180214.598841:VERBOSE2:redeem_unblinded_token.cc(113)] GET /v1/confirmation/{confirmation_id}/paymentToken
[6571:259:0802/180214.598896:VERBOSE5:redeem_unblinded_token.cc(117)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/447b02a5-9af6-42ec-bfb1-eda71c806b60/paymentToken
  Method: GET
[6571:259:0802/180214.724292:VERBOSE1:redeem_unblinded_token.cc(128)] OnFetchPaymentToken
[6571:259:0802/180214.724422:VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/447b02a5-9af6-42ec-bfb1-eda71c806b60/paymentToken
  Response Status Code: 200
  Response: {"id":"447b02a5-9af6-42ec-bfb1-eda71c806b60","createdAt":"2021-08-03T01:02:14.594Z","type":"view","modifiedAt":"2021-08-03T01:02:14.619Z","creativeInstanceId":"033a95ca-963b-460c-b203-8181346bd41c","paymentToken":{"publicKey":"JiwFR2EU/Adf1lgox+xqOVPuc6a/rxdy/LguFG5eaXg=","batchProof":"nCanVupXdnSAwpLZmoHrdZ/zP9qkGWewS8ck2Rc/FAyneako2Kb0KRGoA3HtU0TF42guQFH1EkVRh7M7bu6hAA==","signedTokens":["fI/he2cd9E3DTIsg8dJMYyDDdqzPn4MEIGkcFjkFfHA="]}}
[6571:259:0802/180214.725202:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id 447b02a5-9af6-42ec-bfb1-eda71c806b60, creative instance id 033a95ca-963b-460c-b203-8181346bd41c and view
[6571:259:0802/180214.725776:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens

Screen Shot 2021-08-02 at 6 03 48 PM

@kjozwiak
Copy link
Member

kjozwiak commented Aug 3, 2021

Moving this into 1.28.x as it was fixed by brave/brave-core#9327 which was uplifted into 1.28.x via brave/brave-core#9599. I also removed closed/works-for-me and added QA Pass-macOS as it was verified by @stephendonner via #17062 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants