Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up/rename Brave Together code references to Brave Talk #17138

Closed
stephendonner opened this issue Jul 23, 2021 · 0 comments · Fixed by brave/brave-core#9605
Closed

Clean up/rename Brave Together code references to Brave Talk #17138

stephendonner opened this issue Jul 23, 2021 · 0 comments · Fixed by brave/brave-core#9605
Assignees
@bsclifton
Labels
needs-text-change This change requires some careful wording. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.28.x - Release

Comments

@stephendonner
Copy link

Description

Clean up/rename Brave Together code references to Brave Talk

Steps to Reproduce

Search the codebase for braveTogether (https://github.com/brave/brave-core/search?q=braveTogether) and brave together (https://github.com/brave/brave-core/search?q=brave%20Together)

Actual result:

A lot of the code still refers to variants of Brave Together, although we've updated it in the UI to be Brave Talk in most places.

Expected result:

Should be braveTalk and brave talk (etc) for the sake of clarity and consistency. This should be done carefully as with all huge string renames; not merely (only) a search and replace.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.29.23 Chromium: 92.0.4515.107 (Official Build) nightly (x86_64)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS macOS Version 11.5 (Build 20G71)
@stephendonner stephendonner added needs-text-change This change requires some careful wording. OS/Desktop labels Jul 23, 2021
@bsclifton bsclifton mentioned this issue Jul 26, 2021
Merged
24 tasks
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 28, 2021
@bsclifton bsclifton self-assigned this Jul 29, 2021
@bsclifton bsclifton mentioned this issue Aug 2, 2021
Merged
24 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Aug 2, 2021
@bsclifton
Rename instances of together
dc9386e 
Originally done as separate commits (one at a time) and compiled/tested after each.

Fixes brave/brave-browser#17138

- Rename `showTogether` => `showBraveTalk`
- Rename `togetherSupported` => `braveTalkSupported`
- Rename constant `kNewTabPageShowTogether` => `kNewTabPageShowBraveTalk`
  (Does not affect actual profile setting)
- Rename Widget (from `TogetherWidget` to `BraveTalkWidget`)
- Rename `togetherPromptDismissed` => `braveTalkPromptDismissed`
- Rename `supportsTogether` => `supportsBraveTalk`
- Rename `saveShowTogether` => `saveShowBraveTalk`
- Rename `toggleShowTogether` => `toggleShowBraveTalk`
- Rename `TogetherTooltip` => `BraveTalkTooltip`
- Rename `TogetherIcon` => `BraveTalkIcon`
- Rename `renderTogetherWidget` => `renderBraveTalkWidget`
- Rename `dismissTogetherPrompt` => `dismissBraveTalkPrompt`
- Rename `onDismissTogetherPrompt` => `onDismissBraveTalkPrompt`
- Rename `togetherBanner` => `braveTalkBanner`
- Rename `TogetherItem` => `BraveTalkItem`
- Rename `BraveTogetherIcon` as `BraveTalkSvg`
bsclifton added a commit to brave/brave-core that referenced this issue Aug 3, 2021
@bsclifton
Rename instances of together
8b42deb 
Originally done as separate commits (one at a time) and compiled/tested after each.

Fixes brave/brave-browser#17138

- Update component namespace (from `brave_together` to `brave_talk`)
- Update extension API (from `braveTogether` to `braveTalk`)
- Update strings (from `together`/`TOGETHER` to `braveTalk`/`BRAVE_TALK`)
- Rename `showTogether` => `showBraveTalk`
- Rename `togetherSupported` => `braveTalkSupported`
- Rename constant `kNewTabPageShowTogether` => `kNewTabPageShowBraveTalk`
  (Does not affect actual profile setting)
- Rename Widget (from `TogetherWidget` to `BraveTalkWidget`)
- Rename `togetherPromptDismissed` => `braveTalkPromptDismissed`
- Rename `supportsTogether` => `supportsBraveTalk`
- Rename `saveShowTogether` => `saveShowBraveTalk`
- Rename `toggleShowTogether` => `toggleShowBraveTalk`
- Rename `TogetherTooltip` => `BraveTalkTooltip`
- Rename `TogetherIcon` => `BraveTalkIcon`
- Rename `renderTogetherWidget` => `renderBraveTalkWidget`
- Rename `dismissTogetherPrompt` => `dismissBraveTalkPrompt`
- Rename `onDismissTogetherPrompt` => `onDismissBraveTalkPrompt`
- Rename `togetherBanner` => `braveTalkBanner`
- Rename `TogetherItem` => `BraveTalkItem`
- Rename `BraveTogetherIcon` as `BraveTalkSvg`
- Rename "widget stack" name from `together` to `braveTalk`
@bsclifton bsclifton added this to the 1.29.x - Nightly milestone Aug 3, 2021
@bsclifton bsclifton mentioned this issue Aug 3, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
needs-text-change This change requires some careful wording. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.28.x - Release
Development

Successfully merging a pull request may close this issue.

Brave Talk code cleanup (renaming) and putting behind flag for Griffin brave/brave-core
4 participants
@stephendonner @kjozwiak @bsclifton @rebron