Flash not properly blocked after clearing browser data

[pilgrim-brave]

Description

Default Flash UI flow is described here: brave/brave-core#116

After clearing browser data, Flash UI flow is identical to Chromium, i.e. not blocked by default, only click-to-play.

[kjozwiak]

@pilgrim-brave could you please add a test case that QA can use to verify that this has been fixed? Thanks!

[pilgrim-brave]

1. Install Flash.
2. Start Brave with a clean profile.
3. Navigate to http://www.y8.com/games/derby_racing and verify that the page content shows "Adobe Flash Player is blocked"
4. Click the plugin icon in the URL bar and verify that the popup dialog shows "Flash was blocked on this page"
5. In the popup dialog, click "Run Flash this time"
6. Verify that the page automatically reloads
7. Verify that the page content now shows "Click to enable Adobe Flash Player"
8. Click the page content area that says "Click to enable Adobe Flash Player" and verify that another popup dialog shows "http://www.y8.com wants to Run Flash" with Block and Allow buttons
9. Click Allow button and verify that Flash game loads
10. Close the tab.
11. Navigate to brave://settings/clearBrowserData and click Advanced tab. From Time range, select "All time". Check "Content settings" (it is not checked by default) and click "Clear data"
12. Open a new tab and repeat steps 3-9. Verify that the sequence of Flash-related permissions is unchanged. Important: if you do not see the "Adobe Flash Player is blocked" message when you repeat step 3, that is a failure. The rest of the sequence should also be unchanged, but skipping that message after clearing content settings represents failure.

[btlechowski]

Verification passed on

Brave	0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Windows 7 x64

Used test plan from #1727 (comment)

Verified passed with

Brave	0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Mac OS X

• Verified test plan from Flash not properly blocked after clearing browser data #1727 (comment)

[kjozwiak]

Added the OS/macOS & OS/Windows labels due to Flash not working with b-c on Linux. @srirambv created #1562. Can't verify on Linux.