Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C94 - URL border blue focus ring issue #18156

Closed
GeetaSarvadnya opened this issue Sep 16, 2021 · 6 comments · Fixed by brave/brave-core#10119
Closed

C94 - URL border blue focus ring issue #18156

GeetaSarvadnya opened this issue Sep 16, 2021 · 6 comments · Fixed by brave/brave-core#10119
Assignees
@simonhong
Labels
bug OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.30.x - Release

Comments

@GeetaSarvadnya
Copy link

Description

C94 - URL border color changed to dark blue

Steps to Reproduce

  1. Clean profile 1.31.44
  2. Open a NTP
  3. URL border color changed to dark blue

Actual result:

URL border color changed to dark blue
image

Expected result:

1.29.x
image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.31.44 Chromium: 94.0.4606.41 (Official Build) nightly (64-bit)
Revision 333e85df3c9b656b518b5f1add5ff246365b6c24-refs/branch-heads/4606@{#845}
OS Windows 10 OS Version 2009 (Build 19043.1165)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @mkarolin @simonhong
@simonhong simonhong mentioned this issue Sep 16, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Sep 16, 2021
@simonhong
Fixed focus ring regression
b364c9d 
fix brave/brave-browser#18156

As upsteam code changed the timing of calling setColor(), our
overriding became no-op. Added FocusRing::GetColor() instead.
@mkarolin mkarolin mentioned this issue Sep 16, 2021
Merged
24 tasks
@GeetaSarvadnya GeetaSarvadnya changed the title C94 - URL border color changed to dark blue C94 - URL border blue focus ring issue Sep 16, 2021
@GeetaSarvadnya
Copy link
Author

blue focus ring issue in set default browser popup
image

@simonhong simonhong self-assigned this Sep 16, 2021
@simonhong simonhong added this to the 1.31.x - Nightly milestone Sep 16, 2021
@simonhong
Copy link
Member

@GeetaSarvadnya button's ring in popup also will be fixed by brave/brave-core#10119

@brave-builds brave-builds mentioned this issue Sep 17, 2021
Merged
7 tasks
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Sep 17, 2021 •
edited by stephendonner
Loading

Verification passed on


Brave | 1.31.50 Chromium: 94.0.4606.50 (Official Build) nightly (64-bit)
-- | --
Revision | 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS | Windows 10 Version 21H1 (Build 19043.1165)

Verified #18156 (comment) and #18156 (comment) and ensured focus ring isn't shown.

NTP
image

Set as default
image

Verified PASSED using

Brave 1.31.51 Chromium: 94.0.4606.50 (Official Build) nightly (x86_64)
Revision 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS macOS Version 11.6 (Build 20G165)

Verified #18156 (comment) and #18156 (comment) and ensured focus ring isn't shown.

example example
Screen Shot 2021-09-17 at 8 48 18 Screen Shot 2021-09-17 at 8 53 59

@kjozwiak
Copy link
Member

Removed both QA Pass-Win64 & QA Pass-macOS as they were checked on 1.31.x. We'll need to do a quick check on either platform with 1.30.x when we kick off the next RC that includes 94.0.4606.54.

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 21, 2021
@LaurenWags
Copy link
Member

labelling as QA/Blocked until a new RC is generated

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Blocked labels Sep 23, 2021
@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.30.84 Chromium: 94.0.4606.54 (Official Build) (x86_64)
-- | --
Revision | c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS | macOS Version 10.15.7 (Build 19H1417)

Confirmed URL focus bar color is no longer blue:

18156

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.30.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed focus ring regression brave/brave-core
5 participants
@stephendonner @kjozwiak @simonhong @LaurenWags @GeetaSarvadnya