Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promoCode is not claimed after going offline during installation #1818

Closed
btlechowski opened this issue Oct 24, 2018 · 3 comments
Closed

promoCode is not claimed after going offline during installation #1818

btlechowski opened this issue Oct 24, 2018 · 3 comments

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. (Important) Uninstall Brave Browser with User Data to have a Clean install
    image
  2. (On Windows )Download stub/mini installer and rename it to BraveBrowserSetup-KAM253.exe
  3. Run the stub/mini installer
  4. During installation go offline
    image
  5. After Brave is launched by installer, wait 60 seconds
  6. Go online and wait another 60 seconds
  7. Check if promoCode file exists
  8. Check Local State file for promo_code

Note: promoCode and Local State files are located in AppData\Local\BraveSoftware\Brave-Browser\User Data\ on Windows

Actual result:

promoCode is not claimed
promo_code is not added to Local State

IMPORTANT: Combined with #1811 the promoCode will never be claimed.

Expected result:

promoCode is claimed
promo_code is added to Local State

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

@kjozwiak Can you check on Mac?
cc @srirambv @LaurenWags @GeetaSarvadnya @emerick

@btlechowski btlechowski added this to the 0.55.x - Release Hotfix 2 milestone Oct 24, 2018
@btlechowski btlechowski changed the title promoCode is never claimed after going offline during installation promoCode is not claimed after going offline during installation Oct 24, 2018
@emerick
Copy link
Contributor

emerick commented Oct 24, 2018

The problem is that our attempt to contact the referral server will fail when you're offline. Once #1811 is fixed, this should no longer be a problem (although you would need to restart Brave after coming back online, as we only make the referral check at startup).

@emerick
Copy link
Contributor

emerick commented Oct 25, 2018

Closing now that #1811 is merged. @btlechowski please let me know how it looks now (see above comment).

@emerick emerick closed this as completed Oct 25, 2018
@GeetaSarvadnya
Copy link

Verification passed on:

Brave 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

Local state file:
image

Build id and promo code added in Local state file after online:
download_id":"62a46706-a125-48f4-a916-0edab830b7c8","promo_code":"sge733"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants