Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--variations-server-url= switch doesn't work under Command Line String via QA developer settings #18577

Closed
kjozwiak opened this issue Oct 6, 2021 · 1 comment · Fixed by brave/brave-core#10408

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Oct 6, 2021

Description

Looks like --variations-server-url= doesn't work when it's added into Command Line String. Examples:

  • --variations-server-url=https://no-thanks.invalid still pulls the production seed/variations after restarting
  • --variations-server-url=https://variations.bravesoftware.com/seed still pulls the production seed/variations after restarting

Even though the above appear in brave://version when used, we're still pulling the seed/variations from production. This bug is making it really difficult to QA anything related to Griffin unless the changes are uplifted into production.

This was reproduced by @srirambv @GeetaSarvadnya and myself so it's definitely an issue.

Steps to reproduce

  1. launch and version of Brave
  2. go into Developer options -> QA Preferences
  3. tap on Command Line String
  4. insert/type one of the following
* --variations-server-url=https://no-thanks.invalid
* --variations-server-url=https://variations.bravesoftware.com/seed
  1. restart Brave twice and go into brave://version to make sure that you pulled the seed/variations

You'll notice that we're still pulling the seed/variations from production. For example, using --variations-server-url=https://no-thanks.invalid` shouldn't pull anything form production.

Actual result

--variations-server-url= should be working when added into Command Line String

Expected result

Adding --variations-server-url= into Command Line String doesn't work.

Issue reproduces how often

100% reproducible using the above STR.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung S10+ (phone)
  • Android version: Android 11

Brave version

  • Nightly 1.32.44 Chromium: 94.0.4606.71

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @SergeyZhukovsky @bsclifton @anthonypkeane

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 11 running 1.30.89

  • Verified terminal command worked as expected for variations server
    variations
  • Verified terminal command worked as expected for invalid server
    no-thanks
Test case1 : using https://variations.bravesoftware.com/seed
  • Verified setting the URL path and starting brave there was no variation/seed shown on first launch
  • Verified second restart of Brave, seed from https://variations.bravesoftware.co/seed were listed listed under brave://version
First Launch Second Launch
image image
Test case 2: using https://no-thanks.invalid
  • Verified setting the URL path and starting brave there was no variation/seed shown on first launch
  • Verified second restart of Brave, seed from https://variations.bravesoftware.co/seed were listed listed under brave://version
First Launch Second Launch
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants