-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Added ability to set tes variations server prior to first t… #10408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
3f0baf0
to
b043c5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
4c9683f
to
9c5a1b2
Compare
Verification
Terminal commands used: Opens an
Removes the file from
Check if the file
|
First Launch |
Second Launch |
---|---|
Test Case #2
- using https://no-thanks.invalid
Using the commands mentioned above, started Brave and ensured:
- variations/seed wasn't appearing under
brave://version
on the first launch - restarted Brave and ensured no variations/seeds were listed under
brave://version
due to using https://no-thanks.invalid
First Launch |
Second Launch |
---|---|
…ime run
Resolves brave/brave-browser#18577
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: