Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Added ability to set tes variations server prior to first t… #10408

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Oct 7, 2021

…ime run

Resolves brave/brave-browser#18577

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Oct 7, 2021
@samartnik samartnik added this to the 1.32.x - Nightly milestone Oct 7, 2021
@samartnik samartnik self-assigned this Oct 7, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik force-pushed the android_test_variations_server branch from 3f0baf0 to b043c5d Compare October 7, 2021 19:46
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samartnik samartnik force-pushed the android_test_variations_server branch from 4c9683f to 9c5a1b2 Compare October 8, 2021 13:34
@samartnik samartnik merged commit 563f295 into master Oct 8, 2021
@samartnik samartnik deleted the android_test_variations_server branch October 8, 2021 15:12
@samartnik samartnik restored the android_test_variations_server branch October 8, 2021 16:37
@samartnik samartnik deleted the android_test_variations_server branch October 8, 2021 17:04
@kjozwiak
Copy link
Member

Verification PASSED using Samsung S10+ on Android 11 using the following build:

1.32.60 Chromium: 95.0.4638.40

Terminal commands used:

Opens an adb shell and creates a filed named brave-test-variations-server-url under /data/local/tmp with the value specified:

  • adb shell "echo 'https://variations.bravesoftware.com/seed' > /data/local/tmp/brave-test-variations-server-url"

Removes the file from /data/local/tmp:

  • adb shell "rm /data/local/tmp/brave-test-variations-server-url"

Check if the file brave-test-variations-server-url still exsists:

  • adb shell "cat /data/local/tmp/brave-test-variations-server-url"

daemonStarted

Test Case #1 - using https://variations.bravesoftware.com/seed

Using the commands mentioned above, started Brave and ensured:

First Launch Second Launch
Screenshot_20211009-223211_Brave - Nightly Screenshot_20211009-221526_Brave - Nightly

Test Case #2 - using https://no-thanks.invalid

Using the commands mentioned above, started Brave and ensured:

  • variations/seed wasn't appearing under brave://version on the first launch
  • restarted Brave and ensured no variations/seeds were listed under brave://version due to using https://no-thanks.invalid
First Launch Second Launch
Screenshot_20211009-223211_Brave - Nightly Screenshot_20211009-223211_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--variations-server-url= switch doesn't work under Command Line String via QA developer settings
4 participants