Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BraveForgetFirstPartyStorage on 10% release. #715

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Aug 14, 2023

No description provided.

@goodov goodov requested a review from a team as a code owner August 14, 2023 10:10
@goodov goodov merged commit 847456c into main Aug 14, 2023
@goodov goodov deleted the fbd-release-10 branch August 14, 2023 10:28
@kjozwiak
Copy link
Member

kjozwiak commented Aug 18, 2023

Windows 11 x64

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.54.25 Chromium: 114.0.5735.90 (Official Build) nightly (64-bit)
-- | --
Revision | 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Release - BraveForgetFirstPartyStorage:Enabled

  • downloaded/installed 1.54.25 Chromium: 114.0.5735.90 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveForgetFirstPartyStorage isn't visible under brave://version
  • ensured that the Forget me when I close this site toggle doesn't appear via the shields panel
  • ensured that the Forget me when I close this site toggle doesn't appear via brave://settings/shields
Example Example Example
image image image
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveForgetFirstPartyStorage:Enabled via brave://version
  • ensured that the Forget me when I close this site toggle appears/being displayed via the shields panel
  • ensured that the Forget me when I close this site is being displayed via brave://settings/shields
Example Example Example
image image image

Release - BraveForgetFirstPartyStorage:Disabled

  • downloaded/installed 1.54.25 Chromium: 114.0.5735.90 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveForgetFirstPartyStorage isn't visible under brave://version
  • ensured that the Forget me when I close this site toggle doesn't appear via the shields panel
  • ensured that the Forget me when I close this site toggle doesn't appear via brave://settings/shields
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveForgetFirstPartyStorage:Disabled via brave://version
  • ensured that the Forget me when I close this site toggle is NOT appears/being displayed via the shields panel
  • ensured that the Forget me when I close this site is NOT being displayed via brave://settings/shields
Example Example Example
image image image

Pixel 6 (Android)

Verification PASSED on Pixel 6 running Android 14 using the following STR/Cases:

Brave | 1.57.47 Chromium: 116.0.5845.96 (Official Build) (64-bit)
---| ---
Revision | 180d2fdf443f9be410c38fd8c4ccfe7e99ea2b16
OS | Android 14; Build/UPB5.230623.003; 34; REL

Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that Brave was using https://variations.bravesoftware.com/seed which is the staging URL.

image

Release - BraveForgetFirstPartyStorage:Enabled

  • downloaded/installed 1.57.47 Chromium: 116.0.5845.96
  • ensured that BraveForgetFirstPartyStorage isn't visible under brave://version
  • ensured that the Forget me when I close this site toggle doesn't appear via the shields panel
  • ensured that the Forget me when I close this site toggle doesn't appear via Settings - > Brave Shields & privacy
Example Example Example
Screenshot_20230818-022837 Screenshot_20230818-022850 Screenshot_20230818-022856
  • restarted Brave and ensured that BraveForgetFirstPartyStorage:Enabled via brave://version
  • ensured that the Forget me when I close this site toggle appears/being displayed via the shields panel
  • ensured that the Forget me when I close this site is being displayed via Settings - > Brave Shields & privacy
Example Example Example
Screenshot_20230815-145309 Screenshot_20230815-145334 Screenshot_20230815-145342

Release - BraveForgetFirstPartyStorage:Disabled

  • downloaded/installed 1.57.47 Chromium: 116.0.5845.96
  • ensured that BraveForgetFirstPartyStorage isn't visible under brave://version
  • ensured that the Forget me when I close this site toggle doesn't appear via the shields panel
  • ensured that the Forget me when I close this site toggle doesn't appear via Settings - > Brave Shields & privacy
  • restarted Brave and ensured that BraveForgetFirstPartyStorage:Disabled via brave://version
  • ensured that the Forget me when I close this site toggle is NOT appears/being displayed via the shields panel
  • ensured that the Forget me when I close this site is NOT being displayed via Settings - > Brave Shields & privacy
Example Example Example
Screenshot_20230818-014430 Screenshot_20230818-014512 Screenshot_20230818-014518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants