Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BraveEnableAutoTranslate for 25% STABLE #486

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

atuchin-m
Copy link
Collaborator

For #480

@atuchin-m atuchin-m requested a review from a team as a code owner December 16, 2022 17:10
@atuchin-m atuchin-m self-assigned this Dec 16, 2022
@atuchin-m atuchin-m merged commit 79dd5da into main Dec 16, 2022
@atuchin-m atuchin-m deleted the disable-auto-translate-release-25 branch December 16, 2022 17:12
@kjozwiak
Copy link
Member

Desktop verification using Win 11 x64

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.46.144 Chromium: 108.0.5359.128 (Official Build) (64-bit)
-- | --
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Windows 11 Version 22H2 (Build 22621.963)

Release channel

Test Case #1 - BraveAutoTranslateReleaseStudy:Default

  • launch 1.46.144 Chromium: 108.0.5359.128 using --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAutoTranslateReleaseStudy isn't being displayed under brave://version
  • restart brave using --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAutoTranslateReleaseStudy:Default via brave://version
  • visited https://it.wikipedia.org/wiki/Pagina_principale and ensured that Brave Translate was visible via the omnibox
  • ensured that Always translate [language] appeared via the hamburger menu via Brave Translate
  • ensured that Always translate [language] appears right under the languages being detected after translating several websites
Example Example Example Example
image image image image

Test Case #2 - BraveAutoTranslateReleaseStudy:AutoTranslateDisabled

  • launch 1.46.144 Chromium: 108.0.5359.128 using --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAutoTranslateReleaseStudy isn't being displayed under brave://version
  • restart brave using --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAutoTranslateReleaseStudy:AutoTranslateDisabled via brave://version
  • visited https://it.wikipedia.org/wiki/Pagina_principale and ensured that Brave Translate was visible via the omnibox
  • ensured that Always translate [language] isn't appearing via the hamburger menu via Brave Translate
  • ensured that Always translate [language] isn't appearing under the languages that have been detected
Example Example Example
image image image

@kjozwiak
Copy link
Member

Android verification using Pixel 6 running Android 13

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.46.146 Chromium: 108.0.5359.128 (Official Build) (32-bit)
--- | ---
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Android 13; Build/TQ1A.221205.011

Using the method via brave/brave-core#10408 (comment), ensured that the Android device was pointing/using https://variations.bravesoftware.com/seed which is the staging server.

image

Release channel

Test Case #1 - BraveAutoTranslateReleaseStudy:Default

  • launched 1.46.144 Chromium: 108.0.5359.128
  • ensured that BraveAutoTranslateReleaseStudy isn't being displayed under brave://version
  • restart brave and ensured that BraveAutoTranslateReleaseStudy:Default via brave://version
  • visited https://it.wikipedia.org/wiki/Pagina_principale and ensured that Brave Translate was visible at the bottom
  • ensured that Always translate [language] appeared via the hamburger menu via Brave Translate
Example Example Example
Screenshot_20221219-235320 Screenshot_20221219-235344 Screenshot_20221219-235349

Test Case #2 - BraveAutoTranslateReleaseStudy:AutoTranslateDisabled

  • launched 1.46.144 Chromium: 108.0.5359.128
  • ensured that BraveAutoTranslateReleaseStudy isn't being displayed under brave://version
  • restart brave and ensured that BraveAutoTranslateReleaseStudy:AutoTranslateDisabled`` via brave://version`
  • visited https://it.wikipedia.org/wiki/Pagina_principale and ensured that Brave Translate was visible at the bottom
  • ensured that Always translate [language] isn't appearing via the hamburger menu via Brave Translate
Example Example Example
Screenshot_20221220-000351 Screenshot_20221220-000410 Screenshot_20221220-000413

@kjozwiak
Copy link
Member

Quickly went through a spot check before merging/approving into production. Thorough verification's were done via #479 (comment), #479 (comment), brave/brave-browser#27040 (comment) & brave/brave-browser#27040 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants