Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autotranslate for nightly&beta #479

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Dec 6, 2022

For #480

@atuchin-m atuchin-m self-assigned this Dec 6, 2022
@atuchin-m atuchin-m requested a review from a team as a code owner December 6, 2022 14:56
Signed-off-by: Mikhail Atuchin <matuchin@brave.com>
@atuchin-m atuchin-m changed the title Disable autotranslate nightly beta Disable autotranslate for nightly&beta Dec 6, 2022
@atuchin-m atuchin-m force-pushed the disable-autotranslate-nightly-beta branch from 5b5b73e to 3730af6 Compare December 6, 2022 15:04
"NIGHTLY",
"BETA"
],
"min_version": "107.1.47.31",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beta PR hasn't been merged yet.
So this version set in advance to cover the current nightly and a future beta.

@atuchin-m atuchin-m merged commit 7b37aac into main Dec 6, 2022
@kjozwiak kjozwiak deleted the disable-autotranslate-nightly-beta branch December 7, 2022 04:07
@kjozwiak
Copy link
Member

kjozwiak commented Dec 7, 2022

Desktop Cases - Win 11 x64

Nightly channel

Used the STR/Cases that were outlined via brave/brave-core#16185 (comment) including a few other checks.

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.48.33 Chromium: 108.0.5359.94 (Official Build) nightly (64-bit)
-- | --
Revision | 713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS | Windows 11 Version 22H2 (Build 22621.819)

Test Case #1 - AutoTranslateDisabled once Always translate selected via context menu

  • launched 1.48.33 Chromium: 108.0.5359.94 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • visited https://fr.wikipedia.org/wiki and ensured that the Brave Translate icon appears within the URL
  • ensured that Always Translate French was being listed via the context menu under the Brave Translate button
  • enabled/selected Always Translate French and visited several other French pages and ensured they were being translated
  • closed/re-launched using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAutoTranslateStudy:AutoTranslateDisabled via brave://version
  • ensured that https://fr.wikipedia.org/wiki isn't being automatically translated anymore as Always Translate was disabled
  • ensured that you can still manual translate the page by switching between French & English
  • ensured that Choose another language, Never translate, Never translate this site & Page is not in French are working
Example Example Example Example Example
translateAutoEnabledBefore translateAutoEnabledAfterVersion translateAutoEnabledAfter1 translateAutoEnabledAfter2 translateAutoEnabledAfter3

Test Case #2 - AutoTranslateDisabled once Always translate selected once it appears automatically in the button

  • launched 1.48.33 Chromium: 108.0.5359.94 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • visited https://fr.wikipedia.org/wiki and ensured that the Brave Translate icon appears within the URL
  • ensured that Always Translate French was being listed via the context menu under the Brave Translate button
  • visit several sites within https://fr.wikipedia.org/wiki until you see Always translate French under the targeted translations
  • enable/select Always translate French once it appears under the targeted translations
  • closed/re-launched using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAutoTranslateStudy:AutoTranslateDisabled via brave://version
  • ensured that https://fr.wikipedia.org/wiki isn't being automatically translated anymore as Always Translate was disabled
  • ensured that you can still manual translate the page by switching between French & English
  • ensured that Choose another language, Never translate, Never translate this site & Page is not in French are working
Example Example Example Example Example
translateAutoEnabledAfterVersion translateSubMenuBefore1 translateSubMenuBefore2 translateSubMenuBefore3 translateSubMenuBefore4

Test Case #3 - Clean Install/Profile

  • launched 1.48.33 Chromium: 108.0.5359.94 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • closed/re-launched using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAutoTranslateStudy:AutoTranslateDisabled via brave://version
  • visit https://fr.wikipedia.org/wiki and ensure that the Brave Translate is triggered and a translation is offered
  • ensure that Always Translate isn't visible/available via the context menu
  • ensured that Always translate French never appears under the targeted translation after visiting/translating several websites
  • ensured that you can still manual translate the page by switching between French & English
  • ensured that Choose another language, Never translate, Never translate this site & Page is not in French are working
Example Example Example
defaultVersion defaultClean1 defaultClean2

Desktop Cases - Win 11 x64

BETA channel

Used the STR/Cases that were outlined via brave/brave-core#16185 (comment) including a few other checks.

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.47.121 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
-- | --
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Windows 11 Version 22H2 (Build 22621.900)

Test Case #1 - AutoTranslateDisabled once Always translate selected via context menu

  • launched 1.47.121 Chromium: 108.0.5359.99 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • visited https://fr.wikipedia.org/wiki and ensured that the Brave Translate icon appears within the URL
  • ensured that Always Translate French was being listed via the context menu under the Brave Translate button
  • enabled/selected Always Translate French and visited several other French pages and ensured they were being translated
  • closed/re-launched using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAutoTranslateStudy:AutoTranslateDisabled via brave://version
  • ensured that https://fr.wikipedia.org/wiki isn't being automatically translated anymore as Always Translate was disabled
  • ensured that you can still manual translate the page by switching between French & English
  • ensured that Choose another language, Never translate, Never translate this site & Page is not in French are working
Example Example Example Example Example
image image image image image

Test Case #2 - AutoTranslateDisabled once Always translate selected once it appears automatically in the button

  • launched 1.47.121 Chromium: 108.0.5359.99 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • visited https://fr.wikipedia.org/wiki and ensured that the Brave Translate icon appears within the URL
  • ensured that Always Translate French was being listed via the context menu under the Brave Translate button
  • visit several sites within https://fr.wikipedia.org/wiki until you see Always translate French under the targeted translations
  • enable/select Always translate French once it appears under the targeted translations
  • closed/re-launched using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAutoTranslateStudy:AutoTranslateDisabled via brave://version
  • ensured that https://fr.wikipedia.org/wiki isn't being automatically translated anymore as Always Translate was disabled
  • ensured that you can still manual translate the page by switching between French & English
  • ensured that Choose another language, Never translate, Never translate this site & Page is not in French are working
Example Example Example Example Example
image image image image image

Test Case #3 - Clean Install/Profile

  • launched 1.47.121 Chromium: 108.0.5359.99 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • closed/re-launched using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAutoTranslateStudy:AutoTranslateDisabled via brave://version
  • visit https://fr.wikipedia.org/wiki and ensure that the Brave Translate is triggered and a translation is offered
  • ensure that Always Translate isn't visible/available via the context menu
  • ensured that Always translate French never appears under the targeted translation after visiting/translating several websites
  • ensured that you can still manual translate the page by switching between French & English
  • ensured that Choose another language, Never translate, Never translate this site & Page is not in French are working
Example Example Example
image image image

@kjozwiak
Copy link
Member

kjozwiak commented Dec 7, 2022

Android Cases - Pixel 6 running Android 13

Nightly channel

Using the method described via brave/brave-core#10408 (comment), staging was being used as per the following:

image

Used the STR/Cases that were outlined via brave/brave-core#16185 (comment) including a few other checks.

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.48.34 Chromium: 108.0.5359.94 (Official Build) canary (32-bit)
--- | ---
Revision | 713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS | Android 13; Build/TQ1A.221205.011

Test Case #1 - AutoTranslateDisabled once Always translate pages selected via context menu

  • launched 1.48.34 Chromium: 108.0.5359.94
  • visited brave://version and ensured that BraveAutoTranslateStudy:AutoTranslateDisabled wasn't visible
  • visited https://fr.wikipedia.org/wiki and ensured that Brave Translation appeared at the bottom of the page
  • ensured that Always translate pages was visible under the context menu
  • ensured that Pages in French will be translated to English from now on appears at the bottom when Always translate pages has been selected via the context menu
  • ensured that French pages are now automatically being translated
  • restarted the browser and ensured that BraveAutoTranslateStudy:AutoTranslateDisabled via brave://version
  • ensured that pages are not being translated automatically (visited several French and Polish websites)
  • ensured that Always translate pages has been removed from the context menu
Example Example Example Example Example Example
Screenshot_20221206-235957 Screenshot_20221207-000003 Screenshot_20221207-000011 Screenshot_20221207-000249 Screenshot_20221207-000318 Screenshot_20221207-000331
  • ensured that More languages, Never translate pages in [language], Never translate this site & Page is not in [Language] are working as expected via the context menu
  • ensured that you can still always translate the page via Hamburger Menu -> Translate
    • select Never translate pages in [language] and ensure you can still translate the page via the hamburger menu
    • select Never translate this site and ensure that you can still translate the page via the hamburger menu
  • ensured that This site will not be translated appears at the bottom of the website when Never translate this site is selected
  • ensured that Pages in [language] will not be translated appears at the bottom of the website when Never translate this site is selected
Example Example Example Example
Screenshot_20221207-000344 Screenshot_20221207-001043 Screenshot_20221207-001058 Screenshot_20221207-000927

Test Case #2 - Clean Install/Profile

  • launched 1.48.34 Chromium: 108.0.5359.94
  • visited brave://version and ensured that BraveAutoTranslateStudy:AutoTranslateDisabled wasn't visible
  • restarted the browser and ensured that BraveAutoTranslateStudy:AutoTranslateDisabled via brave://version
  • visited https://fr.wikipedia.org/wiki and ensured that Brave Translation appeared at the bottom of the page
  • ensured that Always translate pages wasn't visible via the context menu
Example Example Example Example
Screenshot_20221207-003405 Screenshot_20221207-003424 Screenshot_20221207-003443 Screenshot_20221207-003455

Android Cases - Pixel 6 running Android 13

BETA channel

Using the method described via brave/brave-core#10408 (comment), staging was being used as per the following:

image

Used the STR/Cases that were outlined via brave/brave-core#16185 (comment) including a few other checks.

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.47.121 Chromium: 108.0.5359.99 (Official Build) beta (32-bit)
--- | ---
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Android 13; Build/TQ1A.221205.011

Test Case #1 - AutoTranslateDisabled once Always translate pages selected via context menu

  • launched 1.47.121 Chromium: 108.0.5359.99
  • visited brave://version and ensured that BraveAutoTranslateStudy:AutoTranslateDisabled wasn't visible
  • visited https://fr.wikipedia.org/wiki and ensured that Brave Translation appeared at the bottom of the page
  • ensured that Always translate pages was visible under the context menu
  • ensured that Pages in French will be translated to English from now on appears at the bottom when Always translate pages has been selected via the context menu
  • ensured that French pages are now automatically being translated
  • restarted the browser and ensured that BraveAutoTranslateStudy:AutoTranslateDisabled via brave://version
  • ensured that pages are not being translated automatically (visited several French and Polish websites)
  • ensured that Always translate pages has been removed from the context menu
Example Example Example Example Example Example
Screenshot_20221209-164555 Screenshot_20221209-164614 Screenshot_20221209-164625
Screenshot_20221209-164636 Screenshot_20221209-164658
  • ensured that More languages, Never translate pages in [language], Never translate this site & Page is not in [Language] are working as expected via the context menu
  • ensured that you can still always translate the page via Hamburger Menu -> Translate
    • select Never translate pages in [language] and ensure you can still translate the page via the hamburger menu
    • select Never translate this site and ensure that you can still translate the page via the hamburger menu
  • ensured that This site will not be translated appears at the bottom of the website when Never translate this site is selected
  • ensured that Pages in [language] will not be translated appears at the bottom of the website when Never translate this site is selected
Example Example Example Example
Screenshot_20221209-165044 Screenshot_20221209-165111 Screenshot_20221209-165256 Screenshot_20221209-165311

Test Case #2 - Clean Install/Profile

  • launched 1.47.121 Chromium: 108.0.5359.99`
  • visited brave://version and ensured that BraveAutoTranslateStudy:AutoTranslateDisabled wasn't visible
  • restarted the browser and ensured that BraveAutoTranslateStudy:AutoTranslateDisabled via brave://version
  • visited https://fr.wikipedia.org/wiki and ensured that Brave Translation appeared at the bottom of the page
  • ensured that Always translate pages wasn't visible via the context menu
Example Example Example Example
Screenshot_20221209-165742 Screenshot_20221209-165648 Screenshot_20221209-165710 Screenshot_20221209-165727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants