Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study BraveLocalhostAccessPermissionStudy #672

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 22, 2023

production: #673

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into main so QA can run through the above on staging before uplifting #673 into production.

@kjozwiak kjozwiak merged commit bfb5ccf into main Jun 26, 2023
@kjozwiak kjozwiak deleted the pr-main-5351159506-1 branch June 26, 2023 16:33
@stephendonner
Copy link

stephendonner commented Jun 26, 2023

Verification IN-PROGRESS using

Brave 1.55.15 Chromium: 115.0.5790.40 (Official Build) nightly (64-bit)
Revision 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS Windows 10 Version 22H2 (Build 19045.3086)

Steps:

  1. installed 1.55.15
  2. launched Brave using --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  3. opened brave://version
  4. confirmed no BraveLocalhostAccessPermissionStudy key or value yet
  5. restarted Brave
  6. reopened brave://version
  7. confirmed BraveLocalhostAccessPermissionStudy:Enabled was set
  8. opened brave://flags
  9. also confirmed Default value for the same
  10. loaded https://shivankaul.com/brave/localhost/subresource.html
  11. followed the instructions, and:
  • python3 -m http.server 8000
  • drop a logo.png into the above directory'
  1. shift+reload https://shivankaul.com/brave/localhost/subresource.html
  2. ...
example example example
image image (1) image (2)

@kjozwiak
Copy link
Member

kjozwiak commented Jun 27, 2023

Verification PASSED on Win 11 x64 using the following build(s):

Nightly - BraveLocalhostAccessPermissionStudy enabled

Brave | 1.55.17 Chromium: 115.0.5790.40 (Official Build) nightly (64-bit)
-- | --
Revision | 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS | Windows 11 Version 22H2 (Build 22621.1848)
  • downloaded/installed 1.55.17 Chromium: 115.0.5790.40 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveLocalhostAccessPermissionStudy isn't visible under brave://version

localhostPrompt

Example Example Example Example
localhostPrompt1 localhostPrompt2 localhostPrompt3 localhostPrompt4

BETA - BraveLocalhostAccessPermissionStudy NOT being listed/added

Brave | 1.54.81 Chromium: 115.0.5790.40 (Official Build) beta (64-bit)
-- | --
Revision | 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS | Windows 11 Version 22H2 (Build 22621.1848)
  • downloaded/installed 1.54.81 Chromium: 115.0.5790.40 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveLocalhostAccessPermissionStudy isn't visible under brave://version

image

  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveLocalhostAccessPermissionStudy isn't visible under brave://version

image

Release - BraveLocalhostAccessPermissionStudy NOT being listed/added

Brave | 1.52.126 Chromium: 114.0.5735.133 (Official Build) (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 11 Version 22H2 (Build 22621.1848)
  • downloaded/installed 1.52.126 Chromium: 114.0.5735.133 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveLocalhostAccessPermissionStudy isn't visible under brave://version

image

  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveLocalhostAccessPermissionStudy isn't visible under brave://version

image

@kjozwiak
Copy link
Member

kjozwiak commented Jun 27, 2023

Verification PASSED on Pixel 6 running Android 14 using the following STR/Cases:

Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that Brave was using https://variations.bravesoftware.com/seed which is the staging URL.

image

Nightly - BraveLocalhostAccessPermissionStudy enabled

Brave | 1.55.16 Chromium: 115.0.5790.40 (Official Build) canary (64-bit)
--- | ---
Revision | 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS | Android 14; Build/UPB3.230519.014; 34; REL
  • downloaded/installed 1.54.82 Chromium: 115.0.5790.40 and started Brave
  • ensured that BraveLocalhostAccessPermissionStudy:Enabled is visible under brave://version

Screenshot_20230627-123439

  • restarted Brave and ensured that BraveLocalhostAccessPermissionStudy:Enabled via brave://version

Screenshot_20230627-123508

BETA - BraveLocalhostAccessPermissionStudy NOT being listed/added

Brave | 1.54.82 Chromium: 115.0.5790.40 (Official Build) beta (64-bit)
--- | ---
Revision	071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS	Android 14; Build/UPB3.230519.014; 34; REL
  • downloaded/installed 1.54.82 Chromium: 115.0.5790.40 and started Brave
  • ensured that BraveLocalhostAccessPermissionStudy isn't visible under brave://version

Screenshot_20230627-122414

  • restarted Brave and ensured that BraveLocalhostAccessPermissionStudy isn't visible under brave://version

Screenshot_20230627-122613

Release - BraveLocalhostAccessPermissionStudy NOT being listed/added

Brave | 1.52.126 Chromium: 114.0.5735.133 (Official Build) (32-bit)
--- | ---
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Android 14; Build/UPB3.230519.014; 34; REL
  • downloaded/installed 1.52.126 Chromium: 114.0.5735.133 and started Brave
  • ensured that BraveLocalhostAccessPermissionStudy isn't visible under brave://version

Screenshot_20230627-123017

  • restarted Brave and ensured that BraveLocalhostAccessPermissionStudy isn't visible under brave://version

Screenshot_20230627-123035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants