-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Study BraveLocalhostAccessPermissionStudy #672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Merging into main
so QA can run through the above on staging
before uplifting #673 into production
.
Verification
|
Brave | 1.55.15 Chromium: 115.0.5790.40 (Official Build) nightly (64-bit) |
---|---|
Revision | 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979} |
OS | Windows 10 Version 22H2 (Build 19045.3086) |
Steps:
- installed
1.55.15
- launched Brave using
--enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- opened
brave://version
- confirmed no
BraveLocalhostAccessPermissionStudy
key or value yet - restarted Brave
- reopened
brave://version
- confirmed
BraveLocalhostAccessPermissionStudy:Enabled
was set - opened
brave://flags
- also confirmed
Default
value for the same - loaded
https://shivankaul.com/brave/localhost/subresource.html
- followed the instructions, and:
python3 -m http.server 8000
- drop a
logo.png
into the above directory'
- shift+reload
https://shivankaul.com/brave/localhost/subresource.html
- ...
example | example | example |
---|---|---|
Verification PASSED on
|
Example |
Example |
Example |
Example |
---|---|---|---|
BETA
- BraveLocalhostAccessPermissionStudy
NOT being listed/added
Brave | 1.54.81 Chromium: 115.0.5790.40 (Official Build) beta (64-bit)
-- | --
Revision | 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS | Windows 11 Version 22H2 (Build 22621.1848)
- downloaded/installed
1.54.81 Chromium: 115.0.5790.40
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveLocalhostAccessPermissionStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveLocalhostAccessPermissionStudy
isn't visible underbrave://version
Release
- BraveLocalhostAccessPermissionStudy
NOT being listed/added
Brave | 1.52.126 Chromium: 114.0.5735.133 (Official Build) (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 11 Version 22H2 (Build 22621.1848)
- downloaded/installed
1.52.126 Chromium: 114.0.5735.133
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveLocalhostAccessPermissionStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveLocalhostAccessPermissionStudy
isn't visible underbrave://version
Verification PASSED on Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that
|
production
: #673