Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not request randomness server info if P3A is disabled #38712

Closed
DJAndries opened this issue May 30, 2024 · 2 comments · Fixed by brave/brave-core#24516
Closed

Do not request randomness server info if P3A is disabled #38712

DJAndries opened this issue May 30, 2024 · 2 comments · Fixed by brave/brave-core#24516
Assignees
@DJAndries
Labels
bug features/P3A network/startup requests OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.70.x - Release

Comments

@DJAndries
Copy link
Collaborator

DJAndries commented May 30, 2024 •
edited by fmarier
Loading

Steps to reproduce:

  1. Create a new profile.
  2. Start the browser with that profile, disable all data collection in brave://settings/privacy.
  3. Close the browser.
  4. Start a local mitmproxy: mitmproxy --mode socks5 --listen-port 9000
  5. Start the browser with that proxy: brave-browser-stable --user-data-dir=/home/francois/brave-temp-profile --proxy-server="socks5://localhost:9000"
  6. Wait for the startup requests to show up in mitmproxy.

Screenshot from 2024-05-30 14-18-37
@DJAndries DJAndries added OS/Android Fixes related to Android browser functionality features/P3A OS/Desktop labels May 30, 2024
@DJAndries DJAndries self-assigned this May 30, 2024
@DJAndries DJAndries added the bug label May 30, 2024
@DJAndries DJAndries mentioned this issue Jul 4, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Jul 22, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 6, 2024 •
edited
Loading

Verification PASSED on

Brave | 1.70.51 Chromium: 127.0.6533.88 (Official Build) nightly (64-bit)
-- | --
Revision | c39ff5a89233f396d214b305233de91ff13a8b9e
OS | Windows 10 Version 22H2 (Build 19045.4651)

Verified the test plan from brave/brave-core#24516

  • Confirmed that the requests are NOT send to the endpoints collector.bsg.brave.com and star-randsrv.bsg.brave.com when P3A settings is disabled via brave://settings/privacy
Example Example
image (4) image (5)
  • Confirmed that the endpoint p3a-json.brave.com is shown under Charles proxy when P3A settings is enabled and griffin seeds are not loaded via brave://version
Example Example
image (4) image (5)
  • Confirmed that the endpoint p3a-json.brave.com is NOT shown under Charles proxy when P3A settings is enabled and griffin seeds BraveP3AJSONOtherDeprecation and BraveP3ATypicalJSONDeprecationEnabled are loaded via brave://version
Example Example
image (4) image (5)

Confirmed that the metrics are send to the endpoints collector.bsg.brave.com and star-randsrv.bsg.brave.com when P3A settings is enabled via brave://settings/privacy

Example Example star-randsrv.bsg.brave.com collector.bsg.brave.com
image image image image

@GeetaSarvadnya GeetaSarvadnya added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 6, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 28, 2024 •
edited
Loading

Verification PASSED on Samsung Galaxy A52s 5G version 12 running Bravemonoarm64.apk_1.70.92

Verified the test plan from brave/brave-core#24516

  • Confirmed that the requests are NOT send to the endpoints collector.bsg.brave.com and star-randsrv.bsg.brave.com when P3A settings is disabled via brave://settings/privacy
Example Example
Screenshot_20240828_125343_Brave - Beta image
  • Confirmed that the endpoint p3a-json.brave.com is shown under Charles proxy when P3A settings is enabled and griffin seeds are not loaded via brave://version

(On Android - Followed the steps from brave/brave-core#10408 (comment) to set the variation url to https://no-thanks.invalid/ and ensured no variations/seeds were listed under brave://version due to using https://no-thanks.invalid/

Example Example Example Example
image Screenshot_20240828_202641_Brave - Beta Screenshot_20240828_202648_Brave - Beta Screenshot_20240828_202651_Brave - Beta
  • Confirmed that the endpoint p3a-json.brave.com is NOT shown under Charles proxy when P3A settings is enabled and griffin seeds BraveP3AJSONOtherDeprecation and BraveP3ATypicalJSONDeprecationEnabled are loaded via brave://version
Example Example Example
Screenshot_20240828_134622_Brave - Beta Screenshot_20240828_134658_Brave - Beta image

Confirmed that the metrics are send to the endpoints collector.bsg.brave.com and star-randsrv.bsg.brave.com when P3A settings is enabled via brave://settings/privacy

Example Example star-randsrv.bsg.brave.com collector.bsg.brave.com
Screenshot_20240828_140922_Brave - Beta Screenshot_20240828_140901_Brave - Beta image (1) image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DJAndries DJAndries

Labels
bug features/P3A network/startup requests OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.70.x - Release
Development

Successfully merging a pull request may close this issue.

Start/stop P3A MessageManager depending on P3A enabled setting brave/brave-core
4 participants
@fmarier @DJAndries @GeetaSarvadnya @brave-builds