Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout BraveP3AConstellation feature to all nightly & beta users #665

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

DJAndries
Copy link
Collaborator

@DJAndries DJAndries requested a review from a team as a code owner June 13, 2023 22:42
Copy link
Contributor

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@DJAndries DJAndries merged commit 2e65ee7 into main Jun 13, 2023
@DJAndries DJAndries deleted the star-rollout branch June 13, 2023 23:12
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following STR/Cases:

Quick Note

As per discussion with @DJAndries, the following just checks and ensures that the BraveP3AConstellationBetaNightlyRollout is being enabled on the correct channels. QA verification was done via brave/brave-browser#24338 (comment). Basically checking to see if constellation_prep is being displayed via brave://local-state to prove that the study has been enabled.

Nightly - BraveP3AConstellationBetaNightlyRollout:Enabled

Brave | 1.54.73 Chromium: 115.0.5790.32 (Official Build) nightly (64-bit)
-- | --
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | Windows 11 Version 22H2 (Build 22621.1848)
  • downloaded/installed 1.54.73 Chromium: 115.0.5790.32 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveP3AConstellationBetaNightlyRollout isn't visible under brave://version
  • ensured that constellation_prep isn't appearing under brave://local-state
Example Example
image image
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that constellation_prep is appearing under brave://local-state
Example Example
image image

BETA - BraveP3AConstellationBetaNightlyRollout:Enabled

Brave | 1.53.100 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 11 Version 22H2 (Build 22621.1848)
  • downloaded/installed 1.53.100 Chromium: 114.0.5735.133 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveP3AConstellationBetaNightlyRollout isn't visible under brave://version
  • ensured that constellation_prep isn't appearing under brave://local-state
Example Example
image image
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that constellation_prep is appearing under brave://local-state
Example Example
image image

Release - BraveP3AConstellationBetaNightlyRollout NOT being listed/added

Brave | 1.52.126 Chromium: 114.0.5735.133 (Official Build) (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 11 Version 22H2 (Build 22621.1848)
  • downloaded/installed 1.52.126 Chromium: 114.0.5735.133 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveP3AConstellationBetaNightlyRollout isn't visible under brave://version
  • ensured that constellation_prep isn't appearing under brave://local-state
Example Example
image image
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that constellation_prep is NOT appearing under brave://local-state
Example Example
image image

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 14 using the following STR/Cases:

Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that Brave was using https://variations.bravesoftware.com/seed which is the staging URL.

image

Quick Note

As per discussion with @DJAndries, the following just checks and ensures that the BraveP3AConstellationBetaNightlyRollout is being enabled on the correct channels. QA verification was done via brave/brave-browser#24338 (comment). Basically checking to see if constellation_prep is being displayed via brave://local-state to prove that the study has been enabled.

Nightly - BraveP3AConstellationBetaNightlyRollout:Enabled

Brave | 1.55.4 Chromium: 115.0.5790.32 (Official Build) canary (64-bit)
--- | ---
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | Android 14; Build/UPB3.230519.014; 34; REL
  • downloaded/installed 1.55.4 Chromium: 115.0.5790.32 and started Brave
  • ensured that BraveP3AConstellationBetaNightlyRollout isn't visible under brave://version
  • ensured that constellation_prep isn't appearing under brave://local-state
Example Example
Screenshot_20230622-145354 Screenshot_20230622-145435
  • restarted Brave and ensured that constellation_prep is appearing under brave://local-state
Example Example
Screenshot_20230622-145459 Screenshot_20230622-145522

BETA - BraveP3AConstellationBetaNightlyRollout:Enabled

Brave | 1.54.76 Chromium: 115.0.5790.32 (Official Build) beta (64-bit)
--- | ---
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | Android 14; Build/UPB3.230519.014; 34; REL
  • downloaded/installed 1.54.76 Chromium: 115.0.5790.32 and started Brave
  • ensured that BraveP3AConstellationBetaNightlyRollout isn't visible under brave://version
  • ensured that constellation_prep isn't appearing under brave://local-state
Example Example
Screenshot_20230622-150304 Screenshot_20230622-150344
  • restarted Brave and ensured that constellation_prep is appearing under brave://local-state
Example Example
Screenshot_20230622-150359 Screenshot_20230622-150415

Release - BraveP3AConstellationBetaNightlyRollout NOT being listed/added

Brave | 1.52.126 Chromium: 114.0.5735.133 (Official Build) (32-bit)
--- | ---
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Android 14; Build/UPB3.230519.014; 34; REL
  • downloaded/installed 1.52.126 Chromium: 114.0.5735.133 and started Brave
  • ensured that BraveP3AConstellationBetaNightlyRollout isn't visible under brave://version
  • ensured that constellation_prep isn't appearing under brave://local-state
Example Example
Screenshot_20230622-160346 Screenshot_20230622-160521
  • restarted Brave and ensured that constellation_prep is NOT appearing under brave://local-state
Example Example
Screenshot_20230622-160521 Screenshot_20230622-160437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants