-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollout BraveP3AConstellation feature to all nightly & beta users #665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
Verification PASSED on
|
Example |
Example |
---|---|
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
constellation_prep
is appearing underbrave://local-state
Example |
Example |
---|---|
BETA
- BraveP3AConstellationBetaNightlyRollout:Enabled
Brave | 1.53.100 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 11 Version 22H2 (Build 22621.1848)
- downloaded/installed
1.53.100 Chromium: 114.0.5735.133
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveP3AConstellationBetaNightlyRollout
isn't visible underbrave://version
- ensured that
constellation_prep
isn't appearing underbrave://local-state
Example |
Example |
---|---|
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
constellation_prep
is appearing underbrave://local-state
Example |
Example |
---|---|
Release
- BraveP3AConstellationBetaNightlyRollout
NOT being listed/added
Brave | 1.52.126 Chromium: 114.0.5735.133 (Official Build) (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 11 Version 22H2 (Build 22621.1848)
- downloaded/installed
1.52.126 Chromium: 114.0.5735.133
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveP3AConstellationBetaNightlyRollout
isn't visible underbrave://version
- ensured that
constellation_prep
isn't appearing underbrave://local-state
Example |
Example |
---|---|
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
constellation_prep
is NOT appearing underbrave://local-state
Example |
Example |
---|---|
Verification PASSED on Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that
|
Example |
Example |
---|---|
- restarted
Brave
and ensured thatconstellation_prep
is appearing underbrave://local-state
Example |
Example |
---|---|
BETA
- BraveP3AConstellationBetaNightlyRollout:Enabled
Brave | 1.54.76 Chromium: 115.0.5790.32 (Official Build) beta (64-bit)
--- | ---
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | Android 14; Build/UPB3.230519.014; 34; REL
- downloaded/installed
1.54.76 Chromium: 115.0.5790.32
and startedBrave
- ensured that
BraveP3AConstellationBetaNightlyRollout
isn't visible underbrave://version
- ensured that
constellation_prep
isn't appearing underbrave://local-state
Example |
Example |
---|---|
- restarted
Brave
and ensured thatconstellation_prep
is appearing underbrave://local-state
Example |
Example |
---|---|
Release
- BraveP3AConstellationBetaNightlyRollout
NOT being listed/added
Brave | 1.52.126 Chromium: 114.0.5735.133 (Official Build) (32-bit)
--- | ---
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Android 14; Build/UPB3.230519.014; 34; REL
- downloaded/installed
1.52.126 Chromium: 114.0.5735.133
and startedBrave
- ensured that
BraveP3AConstellationBetaNightlyRollout
isn't visible underbrave://version
- ensured that
constellation_prep
isn't appearing underbrave://local-state
Example |
Example |
---|---|
- restarted
Brave
and ensured thatconstellation_prep
is NOT appearing underbrave://local-state
Example |
Example |
---|---|
#664