Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollout P3A Nebula to 10% of release users #1109

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Rollout P3A Nebula to 10% of release users #1109

merged 1 commit into from
Jul 23, 2024

Conversation

DJAndries
Copy link
Collaborator

To be merged after the release of 1.68

@DJAndries DJAndries requested a review from a team as a code owner July 3, 2024 19:17
@kjozwiak
Copy link
Member

kjozwiak commented Jul 8, 2024

We'll push the above into production once 1.68.x hits production as it will include brave/brave-browser#35841.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1109.
    Android: Set the command line to --variations-pr=1109 in debug menu, restart the browser.
    iOS: Set Variations PR to 1109 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

  • Version: pull/1109@429f1fde51c095302e41146503cc7f8ecc5a67fb
  • Uploaded: 2024-07-23T02:20:04.565Z
  • Serial Number: a568b6603815f336685b2f315672656c

kjozwiak
kjozwiak approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into main (staging). Once verified, we'll uplift #1110 into production once 1.68.x goes live.

@kjozwiak kjozwiak merged commit a58c7d6 into main Jul 23, 2024
7 checks passed
@kjozwiak kjozwiak deleted the nebula-release-10 branch July 23, 2024 06:21
@kjozwiak
Copy link
Member

Quick note: The above feature was already verified via the client as per brave/brave-browser#35841 (comment) & brave/brave-browser#35841 (comment). We'll run through a basic verification similar to what we did for Nightly & BETA via #1100.

Win x64 verification

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.68.131 Chromium: 127.0.6533.73 (Official Build) (64-bit)
-- | --
Revision | 8167dd98e054f33ff258260aaf64d2eba8110772
OS | Windows 11 Version 23H2 (Build 22631.3958)

BraveP3ANebulaRelease:Default

  • launched 1.68.131 Chromium: 127.0.6533.73 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
  • re-launched 1.68.131 Chromium: 127.0.6533.73 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveP3ANebulaRelease:Default via brave://version

image

BraveP3ANebulaRelease:Enabled

  • launched 1.68.131 Chromium: 127.0.6533.73 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
  • re-launched 1.68.131 Chromium: 127.0.6533.73 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveP3ANebulaRelease:Enabled via brave://version

image

Android verification

Ensured that Android was using staging using brave/brave-core#10408 (comment).

Brave | 1.68.128 Chromium: 127.0.6533.73 (Official Build) (64-bit)
--- | ---
Revision | 800676fd9ede2eb4174bac98c186e53749c7201f
OS | Android 15; Build/AP31.240617.009; 35; REL

BraveP3ANebulaRelease:Default

  • launched 1.68.128 Chromium: 127.0.6533.73
  • ensured that BraveP3ANebulaRelease:Default via brave://version

Screenshot_20240729-140108

BraveP3ANebulaRelease:Enabled

  • launched 1.68.128 Chromium: 127.0.6533.73
  • ensured that BraveP3ANebulaRelease:Enabled via brave://version

Screenshot_20240729-140541

iOS verification

Brave | 1.68.130 Chromium: 127.0.6533.73 (Official Build) stable (64-bit)
--- | ---
Revision | 841d137ffede...
OS | iOS

BraveP3ANebulaRelease:Default

Quick Note: ensure that the network/internet is disabled when setting the variation URL.

  • install/launched 1.68.130 Chromium: 127.0.6533.73 via TF
  • enable QA Developer Settings and update Variations URL to https://variations.bravesoftware.com/seed
  • close Brave and re-enable network/internet
  • restart Brave one more time
  • ensured that BraveP3ANebulaRelease:Default via brave://version

IMG_0415

BraveP3ANebulaRelease:Enabled

Quick Note: ensure that the network/internet is disabled when setting the variation URL.

  • install/launched 1.68.130 Chromium: 127.0.6533.73 via TF
  • enable QA Developer Settings and update Variations URL to https://variations.bravesoftware.com/seed
  • close Brave and re-enable network/internet
  • restart Brave one more time
  • ensured that BraveP3ANebulaRelease:Default via brave://version

IMG_0416

@kjozwiak kjozwiak mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJAndries @kjozwiak