Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Auto-Contribute" from Rewards Summary for Japan region #18651

Closed
LaurenWags opened this issue Oct 8, 2021 · 3 comments · Fixed by brave/brave-core#10428
Closed

Remove "Auto-Contribute" from Rewards Summary for Japan region #18651

LaurenWags opened this issue Oct 8, 2021 · 3 comments · Fixed by brave/brave-core#10428

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 8, 2021

Description

Rewards panel UI is being refreshed with #14602

Previously line items only displayed on the summary as they occurred. However, with the UI refresh the line items are always there. In the case of Japan region, Auto Contribute is not applicable, so AC should be removed from the summary.

Steps to Reproduce

  1. Install 1.31.x with Japan region, staging env
  2. Enable Rewards
  3. Look at summary (in my example I have bF wallet connected, but AC should be removed regardless of whether bF wallet is connected or not)

Repeat for Upgrade case also

Actual result:

Auto Contribute is listed in summary but is not applicable to Japan region:

Example Example
Screen Shot 2021-10-08 at 9 32 06 Screen Shot 2021-10-08 at 9 32 20

Expected result:

AC should not be listed in summary for Japan region

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.31.74 Chromium: 94.0.4606.71 (Official Build) beta (x86_64)
Revision 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS macOS Version 10.15.7 (Build 19H1417)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @zenparsing

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 9, 2021

Based on discussions, @zenparsing's solution will be as follows: If Auto-Contribute is disabled, then the line item will disappear from the summary. Since it is always disabled in JP region for now, it will not appear. (If US user has it disabled, it will also not appear.)

@LaurenWags
Copy link
Member Author

Requires 1.31.84 or above to test this issue.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 13, 2021
@LaurenWags
Copy link
Member Author

Verified passed with

Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (x86_64)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | macOS Version 10.15.7 (Build 19H1417)

Confirmed when AC is enabled (US region), Auto Contribute line displays on wallet summary:

Example Example
US AC on US AC on2

Confirmed when AC is disabled (US region), Auto Contribute line does not display on wallet summary:

Example Example
US AC off US AC off2

Confirmed when AC is not available (bitflyer/Japan region), Auto Contribute line does not display on wallet summary:

Example Example
bF1 bF2

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment