Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide AC row in rewards summary when AC is disabled #10428

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Oct 8, 2021

Resolves brave/brave-browser#18651

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Scenario: User with AC disabled

  • Given that the user has disabled AC
  • When the user opens the rewards panel and views the summary
  • Or the user opens brave://rewards
  • Then the "Auto Contribute" row in the rewards summary should not be displayed.

Scenario: User in a bF region

  • Given that the user's profile is associated with a bF region (i.e. Japan)
  • When the user opens the rewards panel and views the summary
  • Or the user opens brave://rewards
  • Then the "Auto Contribute" row in the rewards summary should not be displayed.

@zenparsing zenparsing requested a review from a team as a code owner October 8, 2021 15:35
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing force-pushed the ksmith-hide-autocontribute branch from 5daec8a to 0645a62 Compare October 11, 2021 14:09
@zenparsing zenparsing merged commit ed9d41c into master Oct 11, 2021
@zenparsing zenparsing deleted the ksmith-hide-autocontribute branch October 11, 2021 16:57
brave-builds pushed a commit that referenced this pull request Oct 11, 2021
@zenparsing zenparsing added this to the 1.32.x - Nightly milestone Oct 11, 2021
@LaurenWags
Copy link
Member

Verified using

Brave | 1.32.65 Chromium: 95.0.4638.40 (Official Build) nightly (x86_64)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | macOS Version 10.15.7 (Build 19H1417)

Verified the test plan from #10428 (comment).

Confirmed when in US region with AC off, the Auto Contribute line does not show in the wallet summary from the panel or on brave://rewards page. Confirmed for both clean and upgrade profiles. Also confirmed when AC is on for US region it does show in the wallet summary.

Example Example
US1 US2

Confirmed when in Japan region, the Auto Contribute line does not show in the wallet summary from the panel or on brave://rewards page. Confirmed for both clean and upgrade profiles.

Example Example
J1 J2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Auto-Contribute" from Rewards Summary for Japan region
4 participants