Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure a shortcut is created for launching browser-laptop #1867

Closed
bsclifton opened this issue Oct 26, 2018 · 3 comments
Closed

Ensure a shortcut is created for launching browser-laptop #1867

bsclifton opened this issue Oct 26, 2018 · 3 comments
Assignees
@bsclifton
Labels
closed/invalid OS/Windows

Comments

@bsclifton
Copy link
Member

As part of the upgrade to Brave Core, we need to make sure a shortcut is created which will launch the old version of Brave (browser-laptop/Muon). This shortcut can be dropped on the desktop so that folks have a way to launch back in and:

  • view Brave Payments details / wallet / print reports
  • check out their extension configuration
@bsclifton bsclifton added this to the Muon => Brave Core migration milestone Oct 26, 2018
@bsclifton bsclifton assigned bsclifton and unassigned bsclifton Oct 26, 2018
@bsclifton bsclifton mentioned this issue Oct 26, 2018
Closed
@bsclifton bsclifton self-assigned this Oct 26, 2018
@bsclifton
Copy link
Member Author

Fixed with brave/electron-squirrel-startup#5

@bbondy bbondy removed this from the Muon => Brave Core migration milestone Oct 30, 2018
@bsclifton
Copy link
Member Author

Opening because I didn't see this work when updating on Nightly

@bsclifton bsclifton reopened this Oct 30, 2018
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 1, 2018
@bsclifton
Properly fix brave/brave-browser#1867
ef515fe
@bsclifton
Copy link
Member Author

Fixed with brave/browser-laptop@ef515fe

bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 2, 2018
@bsclifton
Properly fix brave/brave-browser#1867
5c1058b
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 7, 2018
@bsclifton
Properly fix brave/brave-browser#1867
f273278
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 7, 2018
@bsclifton
Properly fix brave/brave-browser#1867
a79fd86
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 7, 2018
@bsclifton
Change the order of operations on Windows brave-core install
66eb6c8 
- install is done last (after possible relaunch due to missing args)
- install is working good; however it's opening brave-core after the silent install

Forcibly create desktop shortcut as a work-around for problems with electron-squirrel-startup
Fixes brave/brave-browser#1867
@bsclifton bsclifton modified the milestones: 0.57.x - Beta, Dupe / Invalid / Not actionable Nov 29, 2018
@bsclifton bsclifton mentioned this issue Nov 29, 2018
Closed
17 tasks
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
closed/invalid OS/Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @bsclifton @srirambv