Missing images in brave:rewards

[btlechowski]

Steps to Reproduce

1. Clean install
2. Go to brave:rewards

Actual result:

Images for Ads, Auto-Contribute, Tips are missing

Expected result:

Reproduces how often:

always

Brave version (brave://version info)

Brave	0.55.21 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Windows 7 x64

Reproduced on Win 10 x64 by @kjozwiak
Not reproducible on Linux and Mac (checked by @kjozwiak and @srirambv )

Reproducible on current release:

no

cc @NejcZdovc @GeetaSarvadnya @LaurenWags

[NejcZdovc]

cc @bridiver I think that we need to pull your PR to 55 as well, because this was not a problem before

[bbondy]

@NejcZdovc What introduced it? We should consider kicking out what introduced it instead of pulling in more things which might or might not fix it

[NejcZdovc]

the only thing that I can think of is big refactor move brave/brave-core#719

Sadly I think we can't back it out. It's just to big and stuff already landed after it

[NejcZdovc]

this only happens on release, can't reproduce on 0.55.x branch directly

[kjozwiak]

this only happens on release, can't reproduce on 0.55.x branch directly

Getting the same results as @NejcZdovc, using Win 10 x64, went through the following:

• 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit) - couldn't reproduce
• 0.56.6 Chromium: 70.0.3538.67 (Official Build) beta (64-bit) - couldn't reproduce
• 0.55.21 Chromium: 70.0.3538.77 (Official Build) (64-bit) - reproduced

[NejcZdovc]

closing as this is not a problem in 56

[GeetaSarvadnya]

Verification Passed on

Brave	0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Windows

Went through verification using the following build under Win 10 x64 - PASSED

Brave	0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Windows