fix resource organization and dependencies

[bridiver]

fix brave/brave-browser#1808

brave browser implementation: brave/brave-browser#1817

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Windows
  • macOS
  • Linux
• Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
  • Windows
  • macOS
  • Linux
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

[bridiver]

there are chromium_src overrides that use generated header files from the resources

[NejcZdovc]

@bridiver please fix linter

[bridiver]

@NejcZdovc not sure what you're referring to

[petemill]

@bridiver We need a corresponding change in brave-browser for the rewards extension messages.json path https://github.com/brave/brave-browser/blob/master/lib/l10nUtil.js#L58

[petemill]

While we're here, 'brave_rewards/resources/ui' directory feels a little weird to me, since it's only 1 part of the ui. Yes it's the thing that renders at brave://rewards so I guess it could be considered the 'main' UI. But is there a clearer directory name, e.g.

components/brave_rewards/resources:
- extension <-- if this becomes a WebUI, it could be called 'rewards-dialog-webui'
- donate-dialog-webui
- tip-dialog-webui <-- soon
- rewards-webui <-- was 'ui'

[bridiver]

@petemill yep, it's weird, but I didn't want to make even more changes in one PR

[bridiver]

mainly I just wanted to get everything grouped under resources and in a grd file for the component

[bridiver]

I think braveComponentsResourcesPath also needs to change to use the string grd file?

[bridiver]

@bbondy anything else you see here for brave-browser changes?

[bridiver]

brave/brave-browser#1817

[bridiver]

maybe the next change I'll make is to move that stuff from brave-browser to brave-core. These linked PRs across the repos really shouldn't be necessary

[bridiver]

I'd really like to expedite this if everything looks good to unblock @SergeyZhukovsky

[NejcZdovc]

@bridiver can you please rebase

[petemill]

Builds and runs 👍

[bridiver]

0.56.x 3317936
0.57.x 0d27933