Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Ads Campaign ID, Daily Cap, Per Day and Total Max use incorrect database fields #1808

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Feb 28, 2019

fixes brave/brave-browser#3530

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • Navigate to www.imdb.com
  • Wait 15 seconds for the browser to idle
  • Open Default/ads_service/client.json
  • campaignHistory array should show the campaign ID and not US

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit 8ccc2ac into master Feb 28, 2019
@tmancey tmancey deleted the issues/3530 branch February 28, 2019 21:20
fmarier pushed a commit that referenced this pull request Oct 29, 2019
petemill pushed a commit that referenced this pull request Jul 27, 2020
petemill pushed a commit that referenced this pull request Jul 28, 2020
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ads Campaign ID, Daily Cap, Per Day and Total Max use incorrect database fields
2 participants