Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads Campaign ID, Daily Cap, Per Day and Total Max use incorrect database fields #3530

Closed
tmancey opened this issue Feb 28, 2019 · 1 comment · Fixed by brave/brave-core#1808

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 28, 2019

Description

Ads Campaign ID, Daily Cap, Per Day and Total Max use incorrect database fields caused by the addition of Region to the database

Steps to Reproduce

  1. Navigate to www.imdb.com
  2. Wait 15 seconds for the browser to idle
  3. Move the mouse

Actual result:

Defaults/ads_service/client.json campaignHistory array shows US

Expected result:

Defaults/ads_service/client.json campaignHistory array should show the campaign ID

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

0.63.x

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional Information

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 8, 2019

Verification passed on both

Brave 0.63.34 Chromium: 74.0.3729.40 (Official Build) beta (64-bit)
Revision 278d6a0d856d8314f36fb9a68b6e1d85cd0d14e7-refs/branch-heads/3729@{#470}
OS Windows 10 OS Build 17134.523
Brave 0.64.37 Chromium: 74.0.3729.40 (Official Build) dev (64-bit)
Revision 278d6a0d856d8314f36fb9a68b6e1d85cd0d14e7-refs/branch-heads/3729@{#470}
OS Windows 10 OS Build 17134.523

Brave Beta:

"campaignHistory": {
"5d7e79b3-8bbb-46d2-b76a-7a2d63d910b9": [
13199195906
]
},

Dev:

"campaignHistory": {
"0441902b-010f-4c95-9d08-505f64387763": [
13199197000
]
},

Verificatoin passed on both

Brave 0.63.40 Chromium: 74.0.3729.61 (Official Build) beta(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Linux
Brave 0.64.47 Chromium: 74.0.3729.61 (Official Build) dev(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Linux

Verified passed with

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment