We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ads Campaign ID, Daily Cap, Per Day and Total Max use incorrect database fields caused by the addition of Region to the database
Defaults/ads_service/client.json campaignHistory array shows US
Defaults/ads_service/client.json
US
Defaults/ads_service/client.json campaignHistory array should show the campaign ID
Easily reproduced
0.63.x
The text was updated successfully, but these errors were encountered:
Resolved Ads Campaign ID, Daily Cap, Per Day and Total Max use incorr…
8ccc2ac
…ect database fields fixes brave/brave-browser#3530
Verification passed on both
Brave Beta:
"campaignHistory": { "5d7e79b3-8bbb-46d2-b76a-7a2d63d910b9": [ 13199195906 ] },
Dev:
"campaignHistory": { "0441902b-010f-4c95-9d08-505f64387763": [ 13199197000 ] },
Verificatoin passed on both
Verified passed with
Verified test plan from Resolved Ads Campaign ID, Daily Cap, Per Day and Total Max use incorrect database fields brave-core#1808
"campaignHistory": { "ad2a81ac-b8de-421f-8d15-380a7f945b8d": [ 13200006559 ] }
Sorry, something went wrong.
tmancey
Successfully merging a pull request may close this issue.
Description
Ads Campaign ID, Daily Cap, Per Day and Total Max use incorrect database fields caused by the addition of Region to the database
Steps to Reproduce
Actual result:
Defaults/ads_service/client.json
campaignHistory array showsUS
Expected result:
Defaults/ads_service/client.json
campaignHistory array should show the campaign IDReproduces how often:
Easily reproduced
Brave version (brave://version info)
0.63.x
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: