Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U2F Not Working #1875

Closed
ghost opened this issue Oct 28, 2018 · 2 comments · Fixed by brave/brave-core#1896
Closed

U2F Not Working #1875

ghost opened this issue Oct 28, 2018 · 2 comments · Fixed by brave/brave-core#1896
Labels
bug priority/P3 The next thing for us to work on. It'll ride the trains. privacy/feature User-facing privacy- & security-focused feature work. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@ghost
Copy link

ghost commented Oct 28, 2018

Description

U2F does not work anywhere, prompts time out or runs forever.

Steps to Reproduce

  1. Go to the Yubico U2F demo
  2. Register for an account
  3. Try to register a Yubikey

Actual result:

image

Prompt for a key times out or runs forever. Additionally, the indicator on the key will not activate. On Yubikeys, this will result in no uniform blinking.

Expected result:

U2F key successfully registers or allows user to log in.

Reproduces how often:

Always

Brave version (brave://version info)

Brave Dev 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 10 (Build 18262)
Brave 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 10 (Build 18262)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    • This occurs on dev and stable

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    • No
  • Is the issue reproducible on the latest version of Chrome?
    • No. Chromium (71.0.3576.0, not Brave) behaves correctly.

Additional Information

Also tested with GitHub, Google, and Login.gov (which uses WebAuthn) with the same results.

I installed regular Brave just to test, so it's a fresh install.

I am also aware of #324, but unlike that issue, there are no errors in the console and prompts seem to run forever or until they time out instead of being interrupted.

@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.61.50 Chromium: 73.0.3683.67 (Official Build) (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Mac OS X

Verification PASSED on Mint 19.1 x64 using the following build:

Brave 0.61.50 Chromium: 73.0.3683.67 (Official Build) (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Linux

Verification PASSED on Windows 10 x64 using the following build:

Brave 0.61.50 Chromium: 73.0.3683.67 (Official Build) (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows

@kjozwiak
Copy link
Member

Adding the release-notes/exclude, will use #3558 as the main issue for the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority/P3 The next thing for us to work on. It'll ride the trains. privacy/feature User-facing privacy- & security-focused feature work. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants