Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tor window progress is not rendered #19165

Closed
simonhong opened this issue Nov 2, 2021 · 1 comment · Fixed by brave/brave-core#10821
Closed

Tor window progress is not rendered #19165

simonhong opened this issue Nov 2, 2021 · 1 comment · Fixed by brave/brave-core#10821

Comments

@simonhong
Copy link
Member

simonhong commented Nov 2, 2021

Tor private window shows always disconnected
This is regresssion of brave/brave-core#10690
Only happens current nightly version - 1.33.x

err msg from console.

brave_new_tab.bundle.js:3870 New Tab Page fatal error: TypeError: Cannot read properties of undefined (reading 'backgroundWallpaper')
    at Sr (brave_new_tab.bundle.js:3367)
    at newTabData (brave_new_tab.bundle.js:3367)
    at brave_new_tab.bundle.js:3367
    at f (brave_new_tab.bundle.js:3367)
    at brave_new_tab.bundle.js:3367
    at Object.dispatch (brave_new_tab.bundle.js:3367)
    at Object.setInitialData (brave_new_tab.bundle.js:3367)
    at brave_new_tab.bundle.js:3870

STR

  1. Open Tor private window
  2. Check tor initialization progress is updated properly.
@simonhong simonhong self-assigned this Nov 2, 2021
simonhong added a commit to brave/brave-core that referenced this issue Nov 2, 2021
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. regression labels Nov 2, 2021
simonhong added a commit to brave/brave-core that referenced this issue Nov 3, 2021
fix brave/brave-browser#19165

In private profile, wallpaperData will be undefined.
@simonhong simonhong added this to the 1.33.x - Nightly milestone Nov 4, 2021
@stephendonner
Copy link

stephendonner commented Nov 4, 2021

Verified PASSED using

Brave 1.33.62 Chromium: 96.0.4664.27 (Official Build) nightly (x86_64)
Revision 0658dae02ef18b530eda4384920ee23f5e156c55-refs/branch-heads/4664@{#459}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. launched Brave
  3. opened Developer Tools
  4. selected the Console tab
  5. File -> New Private Window with Tor
  6. waited for Tor to successfully initialize
  7. loaded brave.com in a Private window with Tor
  8. checked brave://tor-internals

Confirmed Tor status says Connected, and loads content.

example example example example example
Screen Shot 2021-11-04 at 9 43 52 AM Screen Shot 2021-11-04 at 8 35 39 AM Screen Shot 2021-11-04 at 8 36 04 AM Screen Shot 2021-11-04 at 8 36 07 AM Screen Shot 2021-11-04 at 9 46 07 AM

Verified PASSED using

Brave 1.33.82 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 20H2 (Build 19042.1348)

Steps:

  1. new profile
  2. launched Brave
  3. opened Developer Tools
  4. selected the Console tab
  5. File -> New Private Window with Tor
  6. waited for Tor to successfully initialize
  7. loaded brave.com in a Private window with Tor
  8. checked brave://tor-internals

Confirmed Tor status says Connected, and loads content.

example example example example example
19165-1 19165-2 19165-3 19165-4 19165-5

Verified PASSED using

Brave 1.33.85 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Steps:

  1. new profile
  2. launched Brave
  3. opened Developer Tools
  4. selected the Console tab
  5. File -> New Private Window with Tor
  6. waited for Tor to successfully initialize
  7. loaded brave.com in a Private window with Tor
  8. checked brave://tor-internals

Confirmed Tor status says Connected, and loads content.

example example example example example
Screen Shot 2021-11-19 at 5 43 50 PM Screen Shot 2021-11-19 at 5 44 32 PM Screen Shot 2021-11-19 at 5 45 15 PM Screen Shot 2021-11-19 at 5 45 23 PM Screen Shot 2021-11-19 at 5 46 15 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants