Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of tips sites differs between brave://settings/rewards and brave://rewards #19223

Closed
stephendonner opened this issue Nov 3, 2021 · 3 comments · Fixed by brave/brave-core#10876
Assignees
Labels
bug feature/rewards good first issue OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

Description

Order of tips sites differs between brave://settings/rewards and brave://rewards

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. open brave://settings/rewards
  4. open brave://rewards
  5. compare the Tip buttons and Tips sections, respectively, for the above

Actual result:

In brave://settings/rewards, the order is Reddit, Twitter, GitHub

In brave://rewards, the order is Twitter, Reddit, GitHub

brave://settings/rewards brave://rewards
Screen Shot 2021-11-03 at 2 59 08 PM Screen Shot 2021-11-03 at 2 59 22 PM

Expected result:

Perhaps they could just be listed in alphabetical order?

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.33.58 Chromium: 95.0.4638.69 (Official Build) nightly (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)
@stephendonner stephendonner added bug polish Nice to have — usually related to front-end/visual tasks feature/rewards OS/Desktop labels Nov 3, 2021
@stephendonner
Copy link
Author

Their order matches the brave://settings/rewards entry, here, in Tips Settings

Screen Shot 2021-11-03 at 3 05 41 PM

@Tonev
Copy link
Contributor

Tonev commented Nov 4, 2021

@stephendonner @Miyayes

Please, take a look when possible - brave/brave-core#10876.

@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 10, 2021
@zenparsing zenparsing added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 10, 2021
@mihaiplesa mihaiplesa added this to the 1.36.x - Nightly milestone Jan 26, 2022
@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.36.73 Chromium: 98.0.4758.66 (Official Build) nightly (x86_64)
Revision db1b4001d5ce29f141297f260d2b778e000b85a3-refs/branch-heads/4758@{#762}
OS macOS Version 12.2 (Build 21D48)

Confirmed the order is consistently: Reddit, Twitter, and GitHub.

example example example
Screen Shot 2022-01-27 at 1 02 25 AM Screen Shot 2022-01-27 at 1 03 06 AM Screen Shot 2022-01-27 at 1 03 53 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards good first issue OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants