Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes order of tips sites #10876

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Fixes order of tips sites #10876

merged 2 commits into from
Jan 26, 2022

Conversation

Tonev
Copy link
Contributor

@Tonev Tonev commented Nov 4, 2021

Resolves brave/brave-browser#19223

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@stephendonner
Copy link
Contributor

Thanks for the patch! Code looks good to me, but I'm wondering if we want to alphabetize this list, @zenparsing @emerick ?

You didn't know this either, @Tonev but Brave uses the Oxford/Harvard/serial comma, so it would be Reddit, Twitter, and GitHub. as-is.

I'd hold off until we decide ordering; thanks again!

@Tonev
Copy link
Contributor Author

Tonev commented Nov 4, 2021

@stephendonner

I actually thought a comma was missing but was unsure if that was intentional or not so only changed the order of sites. Should be better now, thank you for taking a look ;)

Copy link

@jk10274 jk10274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be alphabeticially ordered?

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tonev
Copy link
Contributor Author

Tonev commented Dec 10, 2021

@emerick

Thanks for approving the changes, but you'll have to merge the pull request, too, if everything is all right since I don't have write access to do so 👍

@emerick emerick self-assigned this Dec 10, 2021
@mihaiplesa mihaiplesa added this to the 1.36.x - Nightly milestone Jan 26, 2022
@mihaiplesa mihaiplesa merged commit 11155fb into brave:master Jan 26, 2022
@mihaiplesa mihaiplesa assigned Tonev and unassigned emerick Jan 26, 2022
@Tonev Tonev deleted the issues/19223 branch January 27, 2022 04:25
muliswilliam pushed a commit that referenced this pull request Jan 28, 2022
* Fixes order of tips sites

* Added a missing comma.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order of tips sites differs between brave://settings/rewards and brave://rewards
5 participants