-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes order of tips sites #10876
Fixes order of tips sites #10876
Conversation
Thanks for the patch! Code looks good to me, but I'm wondering if we want to alphabetize this list, @zenparsing @emerick ? You didn't know this either, @Tonev but Brave uses the Oxford/Harvard/serial comma, so it would be I'd hold off until we decide ordering; thanks again! |
I actually thought a comma was missing but was unsure if that was intentional or not so only changed the order of sites. Should be better now, thank you for taking a look ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be alphabeticially ordered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for approving the changes, but you'll have to merge the pull request, too, if everything is all right since I don't have write access to do so 👍 |
* Fixes order of tips sites * Added a missing comma.
Resolves brave/brave-browser#19223
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: