about:adblock page with regional filters selection followup to #267

[bbondy]

Description

Create an about:adblock page followup to #267. Add regional adblock list similar to muon build

Additional information

#267
Split from #403

[tildelowengrimm]

This should eventually live in global settings. Karen is going to produce some designs for the settings panel.

[bbondy]

sounds good, there's going to be a lot of settings over time though, more than in browser-laptop too. uBlock has multiple tabs.

[tildelowengrimm]

Yeah, I think that having a lot of settings is just the necessary consequence of having a lot of convoluted behaviors which folks might want to twiddle. I think we under-exposed advanced settings in Muon, which is part of the difference.

[emerick]

Our existing behavior (i.e., prior to any changes detailed in this ticket) is that on startup we retrieve the current application locale and start an AdBlock instance for that region if applicable. We also store this "current" AdBlock region in a preference, as there was only the concept of a single active region in this scenario.

How would we want to handle this going forward? The simplest thing would be to eliminate that preference completely and the regional filters are all initially disabled until a user enables them via the brave://adblock/ page. Alternatively we could try to be more clever and remain somewhat backward-compatible with the existing setting, "importing" it into our new regional settings on startup.

@bbondy any thoughts here?

[bbondy]

Just following up for anyone following this issue, Emerick and I talked on Slack and discussed that we'd allow anything to be set, but that'd we'd auto turn on whatever matches the current language setting. The PR is updated with that.

[srirambv]

Verification passed on

Brave	0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision	518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS	Linux

• Custom filter rules not working logged Custom adblock rules should allow cosmetic filters  #4348

Verified passed with

Brave	0.64.72 Chromium: 74.0.3729.131 (Build officiel) beta (64 bits)
Révision	518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
Système d'exploitation	Mac OS X

• Verified test plan from Adblock regional filters selection brave-core#2057

Verification passed on

Brave	0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision	518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS	Windows 10 OS Build 17134.523

Logged #4367
Tested that manually selecting FRA: EasyList Liste FR blocks more elements on https://www.recreatisse.com/