Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an about:adblock page #267

Closed
bbondy opened this issue Jun 4, 2018 · 4 comments
Closed

Create an about:adblock page #267

bbondy opened this issue Jun 4, 2018 · 4 comments

Comments

@bbondy
Copy link
Member

bbondy commented Jun 4, 2018

The first version would be very simple, you can follow along how about:payments is done for a simple example, or about:newtab is done in WebUI for a more complicated example.

It should be the same redux format as the newtab page.

The first version would just say the blocked count.
It would also indicate if a regional list is in use and if so which one it is.

Later we'll add more features to this page like custom filters.

@bbondy bbondy added this to the Backlog milestone Jun 4, 2018
@bsclifton
Copy link
Member

cc: @Snuupy

@bbondy
Copy link
Member Author

bbondy commented Jul 5, 2018

I was doing a task close to this code today so I just took this one too.

@bbondy bbondy modified the milestones: Backlog, Releasable builds Jul 5, 2018
@bbondy
Copy link
Member Author

bbondy commented Jul 5, 2018

As described above, this task is just to get the page working, redux things setup, and display the block count, if region lists are enabled, and if so which one is being used. It's mainly for support for now until we add things like custom lists.

screen shot 2018-07-04 at 9 45 06 pm

bbondy added a commit to brave/brave-core that referenced this issue Jul 5, 2018
bbondy added a commit to brave/brave-core that referenced this issue Jul 5, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@btlechowski
Copy link

btlechowski commented Sep 21, 2018

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

image

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

image

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

screen shot 2018-09-25 at 8 58 57 pm

  • ensured that typing about://adblock directly into the URL loads the page
  • ensured that typing chrome://adblock directly into the URL loads the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants