Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools - "Panel layout" preference is no longer saved #19530

Closed
cyress opened this issue Nov 17, 2021 · 5 comments
Closed

DevTools - "Panel layout" preference is no longer saved #19530

cyress opened this issue Nov 17, 2021 · 5 comments
Labels
closed/duplicate Issue has already been reported OS/Desktop

Comments

@cyress
Copy link

cyress commented Nov 17, 2021

Description

The DevTools settings for the "Panel layout" preference (DevTools > Settings > Preferences > Appearance > Panel Layout) is no longer saved or reset to the default value each time the DevTools are opened.
This behavior occurs in the normal and private browser window.

Steps to Reproduce

  1. Open a website (e.g. https://brave.com/)
  2. Open the DevTools (for example via the keyboard shortcuts)
    macOS: Command+Option+I
    Win: Control+Shift+I
  3. Open the DevTools settings (gear-icon in the upper right)
  4. Change the selected default value for the Panel layout preference from auto to horizontal
  5. Close the DevTools settings
  6. The panels under Elements are now horizontally aligned
  7. Close the DevTools
  8. Reopen the DevTools
  9. The panels under Elements are aligned automatically and the setting for Panel layout is back to auto

Actual result:

After changing the Panel layout preference default value, closing and reopening the DevTools the selected value is reset to the default value auto.

Expected result:

After changing the Panel layout preference, closing and reopening the DevTools the previous selected value is still set and the Elements panels are still aligned accordingly.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 1.32.106 Chromium: 96.0.4664.45 (Official Build) (x86_64)
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | macOS Version 12.0.1 (Build 21A559)

Version/Channel Information:

  • Can you reproduce this issue with the current release? YES
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No
    • This behavior does not occur in the latest Chrome version (96.0.4664.45)
@it-can
Copy link

it-can commented Nov 26, 2021

I have a similair problem, some devtools settings are not saved, like Log XMLHttpRequests very annoying, also on the latest mac os x

@jdahdah
Copy link

jdahdah commented Nov 26, 2021

Can't change the theme of DevTools to dark mode either. I just says "*reload required" when I change the setting, but there is no reload button and neither opening & closing DevTools nor restarting Brave have any effect.

@xyzith
Copy link

xyzith commented Jan 12, 2022

I have same problem. Add custom device won't save either.

@laamp
Copy link

laamp commented Jan 20, 2022

I've also been experiencing this problem. It seems to be specific to Brave. This bug doesn't seem to currently exist in Chrome.

@bsclifton
Copy link
Member

bsclifton commented Mar 18, 2022

Should be fixed with brave/brave-core#12600 - duplicate of #20491

Fix is in Nightly and will be uplifted to Beta and Release channels. Thanks for your patience, folks 😄

@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Desktop
Projects
None yet
Development

No branches or pull requests

6 participants