-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated DevTools prefs override for auto dark mode. #12600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ it seems we also missed DevToolsSettings
changes. 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Verification PASSED on
Went through the STR/Cases outlined via brave/brave-browser#20491 (comment) and also ensured the following:
|
BraveDevToolsUIBindings
failed to load DevTools UI prefs properly which lead to DevTools settings not being persisted, also the sole purpose of this class was to enable dark mode, but now DevTools handles this automatically. Thus it's safe to fully remove this class.Resolves brave/brave-browser#20491
2qdxR11BQN.mp4
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: