Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC721 support #19565

Closed
SergeyZhukovsky opened this issue Nov 18, 2021 · 1 comment · Fixed by brave/brave-core#13229
Closed

ERC721 support #19565

SergeyZhukovsky opened this issue Nov 18, 2021 · 1 comment · Fixed by brave/brave-core#13229
Assignees
@wchen342
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.40.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

No description provided.

@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Nov 18, 2021
@bbondy bbondy added this to Web3 Mar 17, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 17, 2022
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 17, 2022
@wchen342 wchen342 self-assigned this May 2, 2022
@wchen342 wchen342 added this to the 1.40.x - Nightly milestone May 2, 2022
@wchen342 wchen342 mentioned this issue May 2, 2022
Merged
25 tasks
Repository owner moved this from Backlog to Done in Web3 May 11, 2022
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.40.99 x64 Beta build

  • Verified able to add ERC721 tokens as a custom asset
  • Verified ERC721 token is listed under assets
  • Verified entering the contract address automatically loads the token details
  • Encountered #23506, #23507, & #23508

Oppo Reno 5 (Android 12)

Add Token ERC721 listed
image image

Samsung Tab A (Android 10)

Add Token ERC721 listed
image image

@kjozwiak kjozwiak mentioned this issue Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wchen342 wchen342

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Add initial ERC721 support brave/brave-core
4 participants
@bbondy @wchen342 @SergeyZhukovsky @srirambv