Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on NFT shows up as token and lists all accounts available #23507

Closed
srirambv opened this issue Jun 16, 2022 · 1 comment · Fixed by brave/brave-core#15990
Closed
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Clicking on NFT shows up as token and lists all accounts available

Steps to reproduce

  1. Add NFT to portfolio
  2. Click on NFT from portfolio page
  3. Loads similar to token and lists all available/created accounts which is wrong

Actual result

Clicking on NFT shows up as token and lists all accounts available

Expected result

Should not be clickable like desktop until NFT portfolio is done. Also should only list the associated address rather than showing all the available/created accounts

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.40.99

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @wchen342 @SergeyZhukovsky @Pavneet-Sing @jamesmudgett

@srirambv srirambv added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jun 16, 2022
@srirambv srirambv added this to Web3 Jun 16, 2022
@deeppandya deeppandya added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 22, 2022
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Jun 24, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 24, 2022
@Pavneet-Sing Pavneet-Sing removed the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 16, 2022
@wchen342 wchen342 added this to the 1.47.x - Nightly milestone Nov 18, 2022
Repository owner moved this from Backlog to Done in Web3 Nov 18, 2022
@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.47.125 x64 build

Oppo Reno 5 (Android 12) Lenovo Tab (Android 12)
23507-ARM.mp4
23507-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants